Hi,

libgsecuredelete currently fails to build in Debian: see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976579.

This is due to some automake strangeness: generated valac command line
seems wrong, according to Rico Tzschichholz, aka ricotz, upstream Vala
contributor.

The attached patch (courtesy of ricotz) allows to build properly. I also
managed to successfully build and use nautilus-wipe with the resulting lib.

Also, the vapi path follows vala recommendation and is put in
/usr/share/vala/vapi.

It was also suggested the *_vala.stamp file should be deleted before
build to ensure the code is properly generated. I implemented this in
the debian package (to be uploaded soon).

Please, consider including this patch.

Cheers,

-- 
Clément Hermann (nodens)
(with my Tails contributor and Debian Privacy Packaging Team member hats
both on)
Description: Fix valac call generation in gsecuredelete/Makefile.am
 Should avoid "already contains a definition for" errors by using vala properly
Author: Rico Tzschichholz <ric...@ubuntu.com>
Forwarded: yes
Last-Update: 2021-01-11
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
diff --git a/gsecuredelete/Makefile.am b/gsecuredelete/Makefile.am
index c5c62e3..b7dcc18 100644
--- a/gsecuredelete/Makefile.am
+++ b/gsecuredelete/Makefile.am
@@ -26,15 +26,16 @@ libgsecuredelete_la_SOURCES = gsd-async-operation.vala \
                               gsd-swap-operation.vala \
                               gsd-utils.vala \
                               gsd-zeroable-operation.vala
-libgsecuredelete_la_include_HEADERS = gsecuredelete.h \
-                                      gsecuredelete.vapi
+libgsecuredelete_la_include_HEADERS = gsecuredelete.h
+
+vapidir = $(datadir)/vala/vapi
+dist_vapi_DATA = gsecuredelete.vapi
 
 test_VALAFLAGS = $(AM_VALAFLAGS) --vapidir=. --pkg=gsecuredelete
 test_SOURCES = main.vala
 test_LDADD = libgsecuredelete.la
 
 gsecuredelete.vapi: libgsecuredelete_la_vala.stamp
-test_vala.stamp: gsecuredelete.vapi
 
 $(libgsecuredelete_la_SOURCES:.vala=.c): gsd-config.h

Reply via email to