Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package mina2 (Please provide enough (but not too much) information to help the release team to judge the request efficiently. E.g. by filling in the sections below.) [ Reason ] This unblock closes an RC bug that prevents apache-directory-server (apacheds) from starting (#986866). https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986866 [ Impact ] If the bug cascades, it transitively affects apache-directory-api, undertow and zookeeper as a build dependency. [ Tests ] I reproduced the bug locally and the updated libmina2-java has been tested manually with apacheds. [ Risks ] The patch attempts to be minimal by preserving the behavior that has worked until very recently. The patch merely catches and ignores the UnsupportedOperationException when attempting to set SO_SNDBUF on the socket. In that case, the socket will be configured as per the OS default. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] I (briefly) looked into why this bug was noticed only recently when mina2 and apacheds haven't changed in over 6 months. I didn't find an obvious cause; my rationale for addressing this in mina2 is that it is late in the freeze and other possibilities (e.g. openjdk?) would be more complicated. unblock mina2/2.1.4-2
diff -Nru mina2-2.1.4/debian/changelog mina2-2.1.4/debian/changelog --- mina2-2.1.4/debian/changelog 2020-10-17 12:46:40.000000000 -0700 +++ mina2-2.1.4/debian/changelog 2021-05-03 09:05:20.000000000 -0700 @@ -1,3 +1,11 @@ +mina2 (2.1.4-2) unstable; urgency=medium + + * Team upload. + * Add patch to ignore UnsupportedOperationException when setting SO_SNDBUF + in NioSocketAcceptor (Closes: #986866) + + -- tony mancill <tmanc...@debian.org> Mon, 03 May 2021 09:05:20 -0700 + mina2 (2.1.4-1) unstable; urgency=medium * Team upload. diff -Nru mina2-2.1.4/debian/patches/series mina2-2.1.4/debian/patches/series --- mina2-2.1.4/debian/patches/series 2020-10-17 12:46:40.000000000 -0700 +++ mina2-2.1.4/debian/patches/series 2021-05-03 09:05:20.000000000 -0700 @@ -2,3 +2,4 @@ 03-easymock-compatibility.patch 05-spring-dependency.patch maven-bundle-plugin.patch +SO_SNDBUF.patch diff -Nru mina2-2.1.4/debian/patches/SO_SNDBUF.patch mina2-2.1.4/debian/patches/SO_SNDBUF.patch --- mina2-2.1.4/debian/patches/SO_SNDBUF.patch 1969-12-31 16:00:00.000000000 -0800 +++ mina2-2.1.4/debian/patches/SO_SNDBUF.patch 2021-05-03 09:05:20.000000000 -0700 @@ -0,0 +1,25 @@ +Description: no longer throw when setting SO_SNDBUF fails in NioSocketAcceptor +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986866 +Author: tony mancill <tmanc...@debian.org> +Last-Update: 2021-05-02 +Forwarded: no + +--- a/src/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketAcceptor.java ++++ b/src/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketAcceptor.java +@@ -251,9 +251,13 @@ + socket.setReuseAddress(isReuseAddress()); + + // Set the SND BUFF +- if (config.getSendBufferSize() != -1) { +- channel.setOption(StandardSocketOptions.SO_SNDBUF, config.getSendBufferSize()); +- } ++ try { ++ if (config.getSendBufferSize() != -1) { ++ channel.setOption(StandardSocketOptions.SO_SNDBUF, config.getSendBufferSize()); ++ } ++ } catch (UnsupportedOperationException uoe) { ++ // ignored - see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986866 ++ } + + // Set the RCV BUFF + if (config.getReceiveBufferSize() != -1) { File lists identical (after any substitutions) Control files of package libmina2-java: lines which differ (wdiff format) ------------------------------------------------------------------------- Version: [-2.1.4-1-] {+2.1.4-2+} Control files of package libmina2-java-doc: lines which differ (wdiff format) ----------------------------------------------------------------------------- Version: [-2.1.4-1-] {+2.1.4-2+}
signature.asc
Description: PGP signature