Control: tags -1 - moreinfo
Hi GCS,
On Sat, May 29, 2021 at 05:32:59PM +0200, László Böszörményi (GCS) wrote:
> Might you have some time to check if I correctly forward ported your
> patch [1] to the new protobuf release?
Sure.
* Given that you depend on dh-sequence-python3 now, I think you can drop
the dh-python dependency.
* The dh-sequence-python3 dependency also means
that you can drop --with python3, which simplifies your d/rules.
* The conditional CXX assignment can be replaced with:
include /usr/share/dpkg/buildtools.mk
* dh_auto_configure -- --host=... seems suboptimal to me as more flags
depend on the architecture. I recommend using this variant:
dpkg-architecture -f -a$(DEB_BUILD_ARCH) -c dh_auto_configure
* There is now is an alternative to profile conditionals. Instead of
ifneq (,$(filter someprofile,$(DEB_BUILD_PROFILES)))
you may write:
ifneq (,$(filter somepackage,$(shell dh_listpackages)))
The latter makes the steps conditional to the relevant binary
packages, which can be inhibited by either build profiles or by doing
an arch-only/indep-only build. Neither is inherently wrong. I'm just
giving an alternative.
All of the items above are nitpicks. None undermines the usability of
the implementation. Use the ones that make sense to you and ignore the
others.
Helmut
