Source: 0ad
Severity: important
Version: 0.0.25b-1
X-Debbugs-CC: vch...@debian.org rouss...@debian.org

Dear 0ad package maintainers,

https://sources.debian.org/src/0ad/0.0.25b-1/debian/rules/#L15 :

PARALLEL_JOBS=$(shell getconf _NPROCESSORS_ONLN)
ifeq ($(findstring parallel=,$(DEB_BUILD_OPTIONS)),)
        export DEB_BUILD_OPTIONS+=parallel=$(PARALLEL_JOBS)
endif

This really does not make sense; specifying parallel jobs to be the same as
CPU core number will override -j parameter passed to dpkg-buildpackage and
external DEB_BUILD_OPTIONS environment variable (if defined), which may cause
troubles. For example, when preparing backport build for 0ad, my build machine
OOMed due to having too many CPU cores but limited RAM.

Looking back in git history, the idea of using max CPU core seems to be
introduced in ad2190ed4 back in 2012. I am not sure about the rationale behind
it, but perhaps we should drop it in future uploads.

-- 
Thanks,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to