On Fri, 21 Jan 2022 12:08:27 +0100 Alexandre Ghiti <alexandre.gh...@canonical.com> wrote: > On Thu, 20 Jan 2022 18:50:33 +0100 Mattia Rizzolo <mat...@debian.org> wrote: > > Hi Alex, > > > > On Thu, Jan 06, 2022 at 11:19:00AM +0100, Alexandre Ghiti wrote: > > > As the current version we have is from 2017, I bumped the version of > > > this package to the latest available version: I updated the patches, > > > removed the ones that do not apply anymore, updated the build system > > > and dependencies. The result is available in my PPA [2] and fixes the > > > issue we encounter here. > > > > > > Can you consider pulling this? > > > > Thank you for this!! > > > > > > I had a look at your work, however I couldn't help but notice that: > > * the .orig you used looks odd, much larger than what I get from uscan > > (despite yours is also using a different compression, so repacked). > > I used 'git archive' directly, I did not know about uscan (thank you > and Graham). > > > * You did a ton of patch wrangling, including deletion, renaming, > > rebasing, etc. which is all fine, except that the way you did it > > obscures quite a bit what you did. Why did you drop the numbers from > > the patches? Do you have --no-patch-numbers as you gbp-pq default or > > something? > > I changed the patches names since they were different: I fixed that in > my coming MR. Thanks for gbp that I did not know neither. > > > * why requiring gem2deb >=1 ? that's already in bullseye as well in > > focal, so why did you feel the need to add the version? (that's also > > not in the changelog) > > I simply copied the debian/ directory from the previous version that I > got from pull-lp-source, I did not use git...I'll use git in the > future, thanks. > > > > > As such, I went ahead and re-imported the repacked origin I got myself > > in git. > > Could I ask you to submit a MR on top of it, with at least commits > > separating the deletion, refresh and rebasing of patches (and eventual > > new ones, I can't tell at a glance if any new patch appeared…) also > > separated. > > https://salsa.debian.org/ruby-team/ruby-pygments.rb >
> It's on its way :) I can't find how to create a MR in salsa, can you pull directly from here: https://salsa.debian.org/alexghiti/ruby-pygments.rb/-/tree/int/alex/2.3.0 It successfully built in my PPA, if you need any more modification, do not hesitate. Thanks, Alex > > > > > Thank you for your work!! :) > > Thank you for your remarks (and thanks Graham for his help ;)) > > Alex > > > > > -- > > regards,