Package: dgit
Version: 10.2
Severity: normal
While uploading this 3.0 (quilt) package
<https://salsa.debian.org/games-team/steam-installer/-/tree/debian/1%251.0.0.75+ds-1>
to NEW, I got this warning:
> Format `3.0 (quilt)', need to check/update patch stack
> canonical suite name is experimental
> warning: package uses dpkg-source include-binaries feature - not all changes
> are visible in patches!
> warning: ignoring bad include-binaries file debian/icons/16/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/24/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/256/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/32/steam.png: path
> starts with 'debian'
> warning: ignoring bad include-binaries file debian/icons/48/steam.png: path
> starts with 'debian'
According to dpkg-source(1), all non-text files in a 3.0 (quilt) package[1]
need to be listed in debian/source/include-binaries, whether they're
additions to the upstream source or part of the debian/ directory:
> The build will also fail if it finds binary files in the debian
> sub-directory unless they have been allowed through
> debian/source/include-binaries
so I don't think the "ignoring bad include-binaries file" warnings for
those are correct: those lines are valid and necessary.
All files in debian/ are managed by git in the usual way (no special
patch system or anything like that), so dgit should probably only issue
the warning "not all changes are visible in patches" for binaries in
the upstream part of the package, outside debian/.
smcv
[1] the only non-native format that can include Debian-specific binaries
without uuencode or base64, as far as I'm aware
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'stable-security'), (500,
'oldstable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500,
'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1,
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.0.0-6-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages dgit depends on:
ii apt 2.5.4
ii ca-certificates 20211016
ii coreutils 9.1-1
ii curl 7.86.0-3
ii devscripts 2.22.2
ii dpkg-dev 1.21.13
ii dput 1.1.3
ii git [git-core] 1:2.39.0-1
ii git-buildpackage 0.9.30
ii libdpkg-perl 1.21.13
ii libjson-perl 4.10000-1
ii liblist-moreutils-perl 0.430-2
ii liblocale-gettext-perl 1.07-5
ii libtext-csv-perl 2.02-2
ii libtext-glob-perl 0.11-3
ii libtext-iconv-perl 1.7-8
ii libwww-curl-perl 4.17-8+b1
ii perl [libdigest-sha-perl] 5.36.0-6
Versions of packages dgit recommends:
ii distro-info-data 0.56
ii liburi-perl 5.17-1
ii openssh-client [ssh-client] 1:9.1p1-1
Versions of packages dgit suggests:
ii cowbuilder 0.89
ii pbuilder 0.231
ii sbuild 0.84.2
-- no debconf information
