Control: tags -1 confirmed
Control: severity -1 important
Hi, thanks for the report.
Simon McVittie writes ("Bug#1026918: dgit: shows warnings if
debian/source/include-binaries mentions files in debian/"):
> While uploading this 3.0 (quilt) package
> <https://salsa.debian.org/games-team/steam-installer/-/tree/debian/1%251.0.0.75+ds-1>
> to NEW, I got this warning:
>
> > Format `3.0 (quilt)', need to check/update patch stack
> > canonical suite name is experimental
> > warning: package uses dpkg-source include-binaries feature - not all
> > changes are visible in patches!
...
> According to dpkg-source(1), all non-text files in a 3.0 (quilt) package[1]
> need to be listed in debian/source/include-binaries, whether they're
> additions to the upstream source or part of the debian/ directory:
Wait, what? Well, I should have searched the manual more carefully,
evidently. I don't think this behaviour by dpkg-source serves any
kind of purpose (if indeed it still does this thing) but it is dgit's
job to try to cope all these anomalies.
> so I don't think the "ignoring bad include-binaries file" warnings for
> those are correct: those lines are valid and necessary.
So, you seem to be correct.
> All files in debian/ are managed by git in the usual way (no special
> patch system or anything like that), so dgit should probably only issue
> the warning "not all changes are visible in patches" for binaries in
> the upstream part of the package, outside debian/.
Yes.
I think this ought to be fixed for bookworm.
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
