On Tue, Feb 07, 2023 at 08:44:50PM +0100, Stephen Kitt wrote: > > Yes, it seems like we’d really need a mips_macros.h implementation on MIPS. > That was my suspicion as well.
> I enabled the test suite, and the result is basically that the library only > works fully on amd64, i386 (nearly, with two test failures out of ~120,000 > test cases), and ia64, which matches the architectures which the library > claims to support. On other architectures, the number of failures varies, up > to 12.5% of test cases on s390x. > > So really I should change the library to [amd64 i386 ia64]... > That's unfortunate. > Do you have a good way of validating whether the library is good enough for > libmongocrypt’s purposes on non-Intel architectures? > libmonogocrypt has a test suite, which we don't execute as part of the package build because of upstream's robust CI. However, we could definitely enable it and it would be sufficient to let us know that the library is adequate for what libmongocrypt needs. That said, upstream is quite close validating that libmongocrypt works with libdfp, so that might provide a near-term alternative if you decide that the best thing to do from a quality perspective is to restrict the architecture list of intelrdfpmath. Regards, -Roberto -- Roberto C. Sánchez
