Hi Shengjing, On 13-04-2023 14:56, Shengjing Zhu wrote:
On Thu, Apr 13, 2023 at 8:12 PM Paul Gevers <elb...@debian.org> wrote:=== RUN TestLogReqRespNoBody logger_test.go:90: request header doesn't match: (2023-04-12T19:18:59.1355402+08:00) INFO: REQUEST: GET https://fakething/dot/com --- FAIL: TestLogReqRespNoBody (0.01s) === RUN TestLogReqRespWithBody logger_test.go:155: request header doesn't match: (2023-04-12T19:18:59.1420497+08:00) INFO: REQUEST: GET https://fakething/dot/com --- FAIL: TestLogReqRespWithBody (0.01s) FAIL FAIL github.com/Azure/go-autorest/logger 0.017sLooks like it was caused by the UTC+8 timezone in the testbed. I agree it's nice to have the tests not depending on the system timezone. But do we really want to bother with that? Could you just ensure all testbeds have the same timezone?
In my opinion we should do both. You don't want people to go figure this out if they try to run the tests themselves in their own timezone. Also, we are only in control of the hosts that Debian uses. Any downstream may run into the same problems.
Paul
OpenPGP_signature
Description: OpenPGP digital signature