Hi Plasma, Quoting David (Plasma) Paul (2023-09-26 22:25:47) > Please accept the attached patch to add support for the <nodoc> build profile > to mmdebstrap. Please let me know if there's anything you'd like me to > clarify or change.
I haven't tried your diff yet, but I've read it and it looks like it does the right thing. Thank you! May I ask in which situation you found yourself wanting to build mmdebstrap without its manual pages? > Some notes on the patch: Because generating the mmtarfilter(1) manpage > requires running the mmtarfilter python script and because that script makes > use of the 'match' keyword that was not introduced until Python 3.10, I've > added a (>= 3.10) version restriction to the python3 build dependency. This > mimics the existing (>= 3.10) versioned dependency on python3 for the > generated binary package. See [1]. This isn't an issue in unstable where the > current version of Python is 3.11, but is useful information for anyone > making backports [2]. > > > [1] > https://salsa.debian.org/debian/mmdebstrap/-/commit/cd4b44e51402e192ac6fb4cb0373eb817e72172e > [2] I initially was trying to build the stable release of mmdebstrap on > oldstable when I hit this issue with oldstable's Python 3.9 erroring > out on the 'match' statement. For my own local backport I ended up just > rewriting the 'match' statement as an 'if-elif-else' block[3]. > [3] Also, FWIW, the mmtarfilter script contains a section of code > headed by a comment explaining that it is for compatibility with Python > versions older than 3.8. As the aforementioned 'match' statement makes > the script in its current form error out with any Python version less than > 3.10, this code path may no longer be necessary. The codepath is still necessary. What is not necessary anymore is to explicitly pass format=tarfile.PAX_FORMAT because that format became the default in 3.8. I adjusted the comment, thank you! cheers, josch
signature.asc
Description: signature
