Hi Nicholas, Thanks for your review! Please see my replies inline below.
Nicholas D Steeves <s...@debian.org> writes: > Control: retitle -1 RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] > [Team] -- Emacs major mode for editing scala source code > > Xiyue Deng <manp...@gmail.com> writes: > > [snip] >> [ Xiyue Deng ] >> * Sync to latest upstream head (5d7cf21). > > Have you asked upstream to tag a release? > Not before your review but done by now at [1] >> * Override clean rules in d/rules to fix building. (Closes: >> #1052917) > > I believe you already know that > > override_dh_auto_clean: > /bin/true > > is an incorrect approach. > Indeed it was not ideal. Upstream depends on Cask to generated the scala-mode-pkg.el file that is used in the clean target to get the name of the generated tarball, and indeed using this lazy approach is incorrect. I've now included the generated pkg file through a patch to make this work in [2]. >> * Modernize d/watch using special substitute strings. > > Ok, but why? > I believe this provides a more robust way of detecting tags and should be an encouraged practices. From my own experience, when I find a d/watch file that doesn't work I may search for other packages to learn from existing practices, and some may not work well as different upstream may follow different conventions. The substitute strings use a more robust and tested regexp that works most of the time, and promoting its use may save people's time instead of working on an ad-hoc regexp. >> * Add more metadata in d/upstream/metadata. > > https://github.com/hvesalai/emacs-scala-mode/commits/master > > is a git history log, not a changelog nor release notes. > I thought the git history log may be considered an alternative form of a Changelog. Looks like I was wrong except for projects that requires the same format across changelog/git history/release notes. I've dropped that line in [3]. >> * Update year and Upstream-Contact and add myself in d/copyright. > > Why did you add yourself? > https://en.wikipedia.org/wiki/Threshold_of_originality > > I'm happy to support your claim, but you'll need to work for it in more > than a "sweat of the brow"/mechanical sense. > To be honest, the only reason I did this is to suppress the "update-debian-copyright" lintian warning which is actually experimental. I believe what I did was in the same nature as SÅ‚awomir did in 2020 though admittedly not to the same extent, so I've reverted this part in [4]. >> * Use xz compression in d/gbp.conf. > > Why is this useful when it has been the default since gbp 0.9.15? > I'm pretty sure that if I don't add this "git deborig" will create the tarball using gzip instead. And it looks like the commit from 0.9.15 just changed the value in the comment[5]. Please let me know if there is any other option that I missed that makes it use xz. > > Best, > Nicholas > I've committed the new changes (sans "Release to unstable" commit) to the team repo and reuploaded to mentors[6]. PTAL, and TIA! [1] https://github.com/hvesalai/emacs-scala-mode/issues/182 [2] https://salsa.debian.org/emacsen-team/scala-mode-el/-/commit/bc32e3dbf3983c5cf8d4eab98be25e67a9016310 [3] https://salsa.debian.org/emacsen-team/scala-mode-el/-/commit/0ddf10c8e88ae0e6d52ce02968dd678aceeab6f7 [4] https://salsa.debian.org/emacsen-team/scala-mode-el/-/commit/203a3d718956f14bc991b61e4bf9a02bdacd1756 [5] https://salsa.debian.org/agx/git-buildpackage/-/commit/d1960b3dc0dfbb6be2183e555e615864468b234c [6] https://mentors.debian.net/package/scala-mode-el/ -- Xiyue Deng
signature.asc
Description: PGP signature