Control: retitle 983138 ypserv: /bin/sh symlink triggers differences in pwupdate
On 2022-08-05, Vagrant Cascadian wrote: > On 2022-08-05, Vagrant Cascadian wrote: >> On 2022-08-05, Francesco P. Lovergine wrote: >>> On Sun, Jul 17, 2022 at 01:52:46PM +0100, Simon McVittie wrote: >>>>On Fri, 19 Feb 2021 at 14:38:09 -0800, Vagrant Cascadian wrote: >>>>> The configure script sets the BASH variable to /bin/sh when run on a >>>>> usrmerge system, resulting in the pwupdate script differing between >>>>> builds: >>>>> >>>>> >>>>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/ypserv.html >>>>> >>>>> ./usr/lib/yp/pwupdate >>>>> >>>>> #!/bin/bash >>>>> vs. >>>>> #!/bin/sh ... >>>>Regardless of whether this is RC or not, it would be great to have it fixed >>>>for Debian 12. Vagrant's patch looks appropriate. >>>> >>>>Thanks, >>>> smcv >>> >>> The patch looks good enough to fix the pwupdate generation. In any case, the >>> script seems currently POSIX compliant, so using /bin/bash or /bin/sh looks >>> indifferent. >> >> Given that it's the BASH variable, I figured using /bin/bash would make >> more sense and allow consistent builds. ... > From some local testing, this doesn't actually appear to be a usrmerge > issue, but a /bin/sh -> /bin/bash vs. /bin/sh -> /bin/dash issue. Updated bug title accordingly. > I'm not sure why the reproducible builds infrastructure doesn't catch > this, will look into it... Apparently we had some misconfiguration that did not catch this, but it is fixed now, and ypserv is again showing as unreproducible due to this issue: https://tests.reproducible-builds.org/debian/rb-pkg/trixie/amd64/diffoscope-results/ypserv.html > Regardless, the patch would make the package build reproducibly, and > would be great to apply. I would like to perform an NMU fixing this in the near future, barring any strong objections. Apparently either BASH=/bin/sh or BASH=/bin/bash work, though the current shipped package uses /bin/bash in /usr/lib/yp/pwupdate, so my proposed patch to pass BASH=/bin/bash would result in the same behavior as currently in the archive. live well, vagrant
signature.asc
Description: PGP signature
