Control: severity -1 important

Hi,

On Wed, Jul 22, 2020 at 02:44:00PM +0300, Dmitry Shachnev wrote:
> Dear Maintainer,
> 
> You are receiving this bug because your package seems to be using PyQt5
> and has Python files with "import sip" lines.
> 
> With the latest version of PyQt5 in experimental, the private sip module
> used by PyQt5 is called "PyQt5.sip", not just "sip". I am going to upload
> this version to unstable around end of August.
> 
> You may need to update your imports to do something like this:
> 
> try:
>     from PyQt5 import sip
> except ModuleNotFoundError:
>     import sip
> 
> Alternatively, you may import sip after importing PyQt5. So the following
> will work too:
> 
> from PyQt5 import QtCore
> import sip
> 
> Please see the following link for details:
> 
> https://www.riverbankcomputing.com/static/Docs/PyQt5/incompatibilities.html#importing-the-sip-module
> 
> If you use sip for reasons unrelated to PyQt5, you may leave the old import
> as is, but please bear in mind that sip4 is deprecated.
> 
> Also, calls like "sip.setapi('QDate', 2)" are not needed at all with PyQt5.
> They were needed only with PyQt4 and Python 2. It is safe to delete them.
> 
> For the actual documentation of sip module, see the following link:
> 
> https://www.riverbankcomputing.com/static/Docs/PyQt5/api/sip/sip-module.html

It looks like the only file where sip is imported before PyQt5 is
vistrails/packages/CLTools/wizard.py, and it uses sip for setapi() calls
which are, as described in this bug report, no longer needed.

In addition to fixing that file, please also remove python3-sip dependency.
You may want to depend on python3-pyqt5 instead, as it is used in this
package.

I am bumping the severity to important because sip4 is RC-buggy [1] and I am
going to remove it from Debian.

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059648

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature

Reply via email to