Hi Benjamin, On Sun, 03 Mar 2024 16:26:41 +0100 Benjamin Drung <bdr...@debian.org> wrote: > Time to join this discussion. The current default was the preference of > the author 14 years ago. My taste has change a bit since then. I am open > to change the default. --trailing-comma for wrapped lines is a good > idea, --short-indent is okay. I don't like --wrap-always in case there > are only two or three entries. > > The new default should not only based on the preference, but also on > what is used the most. Can someone collect the information: which teams > use which options, how many packages use what?
I did some unscientific research on codesearch looking for d/changelog entries mentioning `wrap-and-sort -` (i.e. wrap-and-sort with some options). This is the query: https://codesearch.debian.net/search?q=path%3Adebian%2Fchangelog+wrap-and-sort+-&literal=1 Apparently -a is the single most used option, very often used together with -s and -t. I found similar results by searching GitHub: https://github.com/search?q=path%3Adebian%2Fchangelog+%22wrap-and-sort+-%22&type=code Looks like salsa (GitLab Free) doesn't allow to do instance-wide code searches. > When we change the default, the parameters to disable those again need > some short options. If we want short parameters for the --no-<action> parameters I think the most sensible option are capital letters (e.g. -T for --no-trailing-comma). In [1] I added the --no-<action> options using argparse.BooleanOptionalAction, which we won't be able to use if we also want short options (we'll need a full parser.add_argument() definition for each I believe). Less nice but not a deal breaker. As not all the people reading the bug may know, there is now a MR aiming at changing the defaults [2]. Cheers, Paride [1] https://salsa.debian.org/debian/devscripts/-/merge_requests/390 [2] https://salsa.debian.org/debian/devscripts/-/merge_requests/392
