On 4/10/24 04:32, Andrey Rakhmatullin wrote:
On Tue, Apr 09, 2024 at 09:50:37PM -0400, Chris Knadle wrote:
Apparently this new bug got introduced with the time_t 64bit transition:
Yes, but it's a valid bug in the package, not a bad thing accidentally
introduced by the transition.
That doesn't sound right.
The zeroc-ice source code does not set the
'-Werror=implicit-function-declaration' build option.
I think these two lines in debian/rules in the package are where CFLAGS
get set:
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk
In other words, whatever bug this is seems to be due to a change in
reasonable default configs from Debian, not in the source.
(?) Can the CFLAGS be cleared with:
DEB_CFLAGS_SET=""
What I don't know is what has to be done now to get zeroc-ice fixed. Does
this require an upload to disable the implict-function-declaration flag
Please don't disable it.
I see two options here: either fix the package to not use $CFLAGS to build
C++ code or fix the package to not use -Werror.
From examining the source, zeroc-ice doesn't set CFLAGS when building
with Linux.The source of CFLAGS being set seems to be set by
dpkg-buildflags
Removing -Werror looks like it would be a simple patch, it seems to be
set here:
config/Make.rules.Linux:cppflags = -Wall -Wextra
-Wredundant-decls -Wshadow -Wdeprecated -Werror -pthread $(if $(filter
yes,$(OPTIMIZE)),-DNDEBUG,-g)
... but this also doesn't sound like the right answer.
But clearing CFLAGS seems like it would be reasonable.
I need to fix this to allow zeroc-ice to transition to Testing, in order to
allow mumble to transition to Testing.
Note that it won't transition to testing before the time64 transition to
to testing is allowed.
--
Chris Knadle
chris.kna...@coredump.us
