On Wed, Apr 10, 2024 at 09:52:44AM -0400, Chris Knadle wrote: > > > Apparently this new bug got introduced with the time_t 64bit transition: > > Yes, but it's a valid bug in the package, not a bad thing accidentally > > introduced by the transition. > That doesn't sound right. > The zeroc-ice source code does not set the > '-Werror=implicit-function-declaration' build option. Yes, Debian sets that.
> I think these two lines in debian/rules in the package are where CFLAGS get > set: > > > DPKG_EXPORT_BUILDFLAGS = 1 > include /usr/share/dpkg/default.mk > > In other words, whatever bug this is seems to be due to a change in > reasonable default configs from Debian, not in the source. The change that led to this FTBFS is of course a change in Debian, not in the package, but the FTBFS happens because flags from CFLAGS set by Debian are used to compile C++ code. Compare `dpkg-buildflags --get CFLAGS` and `dpkg-buildflags --get CXXFLAGS`. > From examining the source, zeroc-ice doesn't set CFLAGS when building with > Linux.The source of CFLAGS being set seems to be set by dpkg-buildflags Of course. > Removing -Werror looks like it would be a simple patch, it seems to be set > here: > > config/Make.rules.Linux:cppflags = -Wall -Wextra -Wredundant-decls > -Wshadow -Wdeprecated -Werror -pthread $(if $(filter > yes,$(OPTIMIZE)),-DNDEBUG,-g) > > ... but this also doesn't sound like the right answer. Yes, it just turns the error into a warning, it's still better to remove the problem that causes this warning, but it's *also* better to not use -Werror when building Debian packages. > But clearing CFLAGS seems like it would be reasonable. I cannot call that reasonable. -- WBR, wRAR
signature.asc
Description: PGP signature
