Control: tags -1 - moreinfo

Le lundi 22 avril 2024 10:12:45 CEST, vous avez écrit :
> Control: tags -1 moreinfo
> 
> On Mon, 22 Apr 2024 09:37:55 +0200 Fab Stz <fabstz...@yahoo.fr> wrote:
> > Package: debhelper
> > Version: 13.15.3
> > Severity: normal
> > 
> > Dear Maintainer,
> > 
> > According to dh_installman, it should honor the nodoc build profile.
> > However, it doesn't. As well as execute_before_dh_install.
> > 
> > 
> > [...]
> 
> Hi,
> 
> Could you please provide the URL the packaging in question where it does
> not work along with a bit more details of what you expected vs. what you
> see? Notably, `dh_installman` will allow documentation to be missing
> during `nodoc` but it will still operate on the documentation there is
> (that has been the way of handling `nodoc` from the start in `debhelper`).
> 
> Additionally, I am not sure what the `execute_before_dh_install` remark
> is about. The `execute_before_dh_install` hook targeted is not affected
> by `nodoc`. First off because it is `dh_install` and not one of the
> `dh_install{docs,man}` and secondly, most of the documentation commands
> still do something even under `nodoc` (unlike `dh_strip` with
> `nostrip`), so the commands are still run. Thirdly, even if it was to be
> affected, it would react to `DEB_BUILD_OPTIONS` and not the profile
> (which are not the same thing and that has been confusing people a lot
> at least with nocheck)
> 
> Best regards,
> Niels

Hello Niels,

Oh sorry, I lost my initial mail and had to rewrite it and wasn't careful 
enough. I meant execute_before_dh_installman and not 
execute_before_dh_install.

Concerning your remark about DEB_BUILD_OPTIONS, it is populated automatically 
with the value of the DEB_BUILD_PROFILES as displayed in the output of dpkg-
buildpackage. At least for nocheck & nodoc.

You can try with https://salsa.debian.org/bastif/mount-zip
Latest commit includes execute_before_dh_installman

For now, as a workaround in that target, I added a test on whether build 
profile has "nodoc" set. But if you remove that "ifneq...", and build with 
"nodoc" it will still invoke both dh_installmal & 
execute_before_dh_installman. However, if one doesn't have pandoc installed 
(eg because the "nodoc" build profile doesn't require it as dependency), that 
target will fail because it is invoked, while I expected it to be skipped.

If you wish to check with that package, I suggest you also build with 
"nocheck", because there is a test that takes a lot of time.

Regards
Fab

Reply via email to