Source: gudhi
Version: 3.7.1+dfsg-1
Severity: normal
Tags: ftbfs
X-Debbugs-Cc: reic...@debian.org
Dear maintainer,
your package fails to build with cgal 6.0~beta1-1, which has recently been
uploaded to experimental. See [1] for the release notes with breaking changes.
[1] https://github.com/CGAL/cgal/releases/tag/v6.0-beta1
Some issues can be fixed just by requiring C++17 (see attached patch). The use
of CGAL_USE_FILE needs to be replaced by target_link_library(... PRIVATE
CGAL::CGAL) (missing in the patch). Finally, CGAL has moved from Qt5 to Qt6.
Best regards,
Joachim
Index: gudhi-3.9.0+dfsg/src/cmake/modules/GUDHI_third_party_libraries.cmake
===================================================================
--- gudhi-3.9.0+dfsg.orig/src/cmake/modules/GUDHI_third_party_libraries.cmake
+++ gudhi-3.9.0+dfsg/src/cmake/modules/GUDHI_third_party_libraries.cmake
@@ -28,12 +28,8 @@ if (FORCE_EIGEN_DEFAULT_DENSE_INDEX_TYPE
add_definitions(-DEIGEN_DEFAULT_DENSE_INDEX_TYPE=int)
endif()
-# In CMakeLists.txt, when include(${CGAL_USE_FILE}), CMAKE_CXX_FLAGS are
overwritten.
-# cf. http://doc.cgal.org/latest/Manual/installation.html#title40
-# A workaround is to include(${CGAL_USE_FILE}) before adding "-std=c++11".
-# A fix would be to use
https://cmake.org/cmake/help/v3.1/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html
-# or even better
https://cmake.org/cmake/help/v3.1/variable/CMAKE_CXX_STANDARD.html
-# but it implies to use cmake version 3.1 at least.
+set(CMAKE_CXX_STANDARD 17)
+
find_package(CGAL QUIET)
# Only CGAL versions > 4.11 supports what Gudhi uses from CGAL
@@ -45,7 +41,6 @@ endif()
if(CGAL_FOUND)
message(STATUS "CGAL version: ${CGAL_VERSION}.")
- include( ${CGAL_USE_FILE} )
endif()
option(WITH_GUDHI_USE_TBB "Build with Intel TBB parallelization" ON)
