Ben, Preamble...
Thank you for taking the time to create this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.
Review...
1. Build[1]: Good
2. Lintian[2]: Good
3. Licenses (lrc[3]): Good
4. Watch file (uscan --force-download): Good
5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
6. Reproducible builds (reporotest)[3]: Good with issue
dpkg-genbuildinfo --build=binary -O../prismlauncher_8.4+ds-1_amd64.buildinfo
dpkg-genchanges --build=binary -O../prismlauncher_8.4+ds-1_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
dpkg-source --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 862, in
run
return 0 if check_func(*check_args) else 1
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 417, in
check_auto
if is_reproducible("1", var_x1):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 411, in
<lambda>
is_reproducible = lambda name, var: test_args.check_reproducible(proc,
dist_x0, name, var)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 353, in
check_reproducible
raise RuntimeError("diffoscope exited non-boolean %s, can't continue" %
retcode)
RuntimeError: diffoscope exited non-boolean -9, can't continue
Possible issue with reprotest. Needs investigating at a later time and not
the responsibility of mentors submitter.
7. Install (No previous installs): Good
8. Upgrade (Over previous installs if any): N/A
Summary...
Good work.
I believe prismlauncher is ready for sponsorship/upload. Could a Debian
Developer (DD) with available free time, please review this package and
upload if you feel it is ready and appropriate for the distribution.
Regards
Phil
[1] Using:
* pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
* https://wiki.debian.org/PbuilderTricks
and
* sbuild - https://wiki.debian.org/sbuild.
[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different, so be thorough.
[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.
[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
