On Sun, Aug 18, 2024 at 10:00:57PM +0200, Stefano Brivio wrote:
> Thanks Uroš for reporting and Faidon for the analysis!

Thanks for the quick response!

> > In this case, there is a comment that states:
> >   * #syscalls clock_gettime arm:clock_gettime64
> > ...but on i386, and likely other 32-bit architectures (like 32-bit arm,
> > which is seemingly already handled), glibc's clock_gettime() is wrapping
> > the clock_gettime64 syscall.
> 
> I tested the full functionality on armhf quite recently, so I don't
> think there should be issues with this, but I'll give it another run.

Was this before or after the time64 (and implicit LFS) transition? This
may affect the syscalls being used by the glibc wrappers... Note that
AIUI i386 is special, as it did not/will not migrate to time64. So it
may just well be that armhf works, but i386 doesn't.

> I'll run the full test suite on i686 and check if anything is missing.
> Unfortunately, I can't easily turn the existing upstream test suite
> into an autopkgtest, because it's rather complicated as it involves
> setting up guests with throughput tests.
> 
> But we're working on a new approach to the test framework that should
> eventually enable some degree of modularity, and make
> running it as part of autopkgtests feasible.

Ah that's great to hear! These issues can be tricky to identify and
diagnose. You could use the "isolation-machine" autopkgtest restriction
(as we do in e.g. crun) to run integration tests, but I think these only
work on amd64 at the moment which makes this moot...

> > 1: "i686" because seccomp.sh calls `uname -m` if there is no TARGET
> > specified, which I think is a (cross-)portability bug of its own...
> 
> On Debian builds (and I guess most other distribution builds, really)
> TARGET is always passed, we use `uname -m` as a fallback option only,
> so that if you just want to type 'make', you can do that. See also
> https://salsa.debian.org/reproducible-builds/reprotest/-/issues/6#note_386163

Ah, I see. What threw me off was that I had to use i686 in the code
comments, rather than i386, which is the Debian arch name.

Thanks!
Faidon

Reply via email to