Bug#1089392: moria: Supporting rootless builds by default

Niels Thykier Sat, 07 Dec 2024 11:54:18 -0800

Source: moria
Version: 5.7.13-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue


Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
moria failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

[ 90%] Building CXX object CMakeFiles/umoria.dir/src/treasure.cpp.o

[ 94%] Building CXX object CMakeFiles/umoria.dir/src/ui.cpp.o
[ 94%] Building CXX object CMakeFiles/umoria.dir/src/ui_inventory.cpp.o

/usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -MD -MT CMakeFiles/umoria.dir/src/ui_inventory.cpp.o -MF CMakeFiles/umoria.dir/src/ui_inventory.cpp.o.d -o CMakeFiles/umoria.dir/src/ui_inventory.cpp.o -c /<<PKGBUILDDIR>>/src/ui_inventory.cpp /usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -MD -MT CMakeFiles/umoria.dir/src/ui.cpp.o -MF CMakeFiles/umoria.dir/src/ui.cpp.o.d -o CMakeFiles/umoria.dir/src/ui.cpp.o -c /<<PKGBUILDDIR>>/src/ui.cpp

[ 96%] Building CXX object CMakeFiles/umoria.dir/src/ui_io.cpp.o
[ 98%] Building CXX object CMakeFiles/umoria.dir/src/wizard.cpp.o

/usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -MD -MT CMakeFiles/umoria.dir/src/ui_io.cpp.o -MF CMakeFiles/umoria.dir/src/ui_io.cpp.o.d -o CMakeFiles/umoria.dir/src/ui_io.cpp.o -c /<<PKGBUILDDIR>>/src/ui_io.cpp /usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -MD -MT CMakeFiles/umoria.dir/src/wizard.cpp.o -MF CMakeFiles/umoria.dir/src/wizard.cpp.o.d -o CMakeFiles/umoria.dir/src/wizard.cpp.o -c /<<PKGBUILDDIR>>/src/wizard.cpp /<<PKGBUILDDIR>>/src/ui.cpp: In function ‘void printCharacterMovementState()’: /<<PKGBUILDDIR>>/src/ui.cpp:336:51: warning: ‘%-3d’ directive writing between 3 and 10 bytes into a region of size 9 [-Wformat-overflow=] 336 | (void) sprintf(repeat_string, "Repeat %-3d", game.command_count);

      |                                                   ^~~~

/<<PKGBUILDDIR>>/src/ui.cpp:336:43: note: directive argument in the range [1, 2147483647] 336 | (void) sprintf(repeat_string, "Repeat %-3d", game.command_count);

      |                                           ^~~~~~~~~~~~~
In file included from /usr/include/stdio.h:970,
                 from /usr/include/c++/14/cstdio:42,
                 from /<<PKGBUILDDIR>>/src/headers.h:40,
                 from /<<PKGBUILDDIR>>/src/ui.cpp:9:
In function ‘int sprintf(char*, const char*, ...)’,

inlined from ‘void printCharacterMovementState()’ at /<<PKGBUILDDIR>>/src/ui.cpp:336:27: /usr/include/aarch64-linux-gnu/bits/stdio2.h:30:34: note: ‘__builtin___sprintf_chk’ output between 11 and 18 bytes into a destination of size 16

   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
[100%] Linking CXX executable umoria/umoria

/usr/bin/cmake -E cmake_link_script CMakeFiles/umoria.dir/link.txt --verbose=1 /usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,--dependency-file,CMakeFiles/umoria.dir/link.d CMakeFiles/umoria.dir/src/config.cpp.o CMakeFiles/umoria.dir/src/helpers.cpp.o CMakeFiles/umoria.dir/src/rng.cpp.o CMakeFiles/umoria.dir/src/main.cpp.o CMakeFiles/umoria.dir/src/data_creatures.cpp.o CMakeFiles/umoria.dir/src/data_player.cpp.o CMakeFiles/umoria.dir/src/data_recall.cpp.o CMakeFiles/umoria.dir/src/data_store_owners.cpp.o CMakeFiles/umoria.dir/src/data_stores.cpp.o CMakeFiles/umoria.dir/src/data_tables.cpp.o CMakeFiles/umoria.dir/src/data_treasure.cpp.o CMakeFiles/umoria.dir/src/character.cpp.o CMakeFiles/umoria.dir/src/dice.cpp.o CMakeFiles/umoria.dir/src/dungeon.cpp.o CMakeFiles/umoria.dir/src/dungeon_generate.cpp.o CMakeFiles/umoria.dir/src/dungeon_los.cpp.o CMakeFiles/umoria.dir/src/game.cpp.o CMakeFiles/umoria.dir/src/game_death.cpp.o CMakeFiles/umoria.dir/src/game_files.cpp.o CMakeFiles/umoria.dir/src/game_objects.cpp.o CMakeFiles/umoria.dir/src/game_run.cpp.o CMakeFiles/umoria.dir/src/game_save.cpp.o CMakeFiles/umoria.dir/src/identification.cpp.o CMakeFiles/umoria.dir/src/inventory.cpp.o CMakeFiles/umoria.dir/src/mage_spells.cpp.o CMakeFiles/umoria.dir/src/monster.cpp.o CMakeFiles/umoria.dir/src/monster_manager.cpp.o CMakeFiles/umoria.dir/src/player.cpp.o CMakeFiles/umoria.dir/src/player_bash.cpp.o CMakeFiles/umoria.dir/src/player_eat.cpp.o CMakeFiles/umoria.dir/src/player_magic.cpp.o CMakeFiles/umoria.dir/src/player_move.cpp.o CMakeFiles/umoria.dir/src/player_pray.cpp.o CMakeFiles/umoria.dir/src/player_quaff.cpp.o CMakeFiles/umoria.dir/src/player_run.cpp.o CMakeFiles/umoria.dir/src/player_stats.cpp.o CMakeFiles/umoria.dir/src/player_throw.cpp.o CMakeFiles/umoria.dir/src/player_traps.cpp.o CMakeFiles/umoria.dir/src/player_tunnel.cpp.o CMakeFiles/umoria.dir/src/recall.cpp.o CMakeFiles/umoria.dir/src/scores.cpp.o CMakeFiles/umoria.dir/src/scrolls.cpp.o CMakeFiles/umoria.dir/src/spells.cpp.o CMakeFiles/umoria.dir/src/staves.cpp.o CMakeFiles/umoria.dir/src/store.cpp.o CMakeFiles/umoria.dir/src/store_inventory.cpp.o CMakeFiles/umoria.dir/src/treasure.cpp.o CMakeFiles/umoria.dir/src/ui.cpp.o CMakeFiles/umoria.dir/src/ui_inventory.cpp.o CMakeFiles/umoria.dir/src/ui_io.cpp.o CMakeFiles/umoria.dir/src/wizard.cpp.o -o umoria/umoria -lncurses /usr/lib/aarch64-linux-gnu/libform.so

make[3]: Leaving directory '/<<PKGBUILDDIR>>'
[100%] Built target umoria
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
/usr/bin/cmake -E cmake_progress_start /<<PKGBUILDDIR>>/CMakeFiles 0
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test

dh_auto_test: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~).

        rm -fr -- /tmp/dh-xdg-rundir-Eu9giVd1
   create-stamp debian/debhelper-build-stamp
   dh_prep
        rm -f -- debian/moria.substvars
        rm -fr -- debian/.debhelper/generated/moria/ debian/moria/ debian/tmp/
   dh_installdirs

dh_installdirs: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~). install -m0755 -d debian/moria/usr/games debian/moria/usr/lib/games/moria debian/moria/usr/share/applications debian/moria/usr/share/icons/hicolor/128x128/apps debian/moria/usr/share/icons/hicolor/256x256/apps debian/moria/usr/share/icons/hicolor/64x64/apps debian/moria/usr/share/icons/hicolor/96x96/apps debian/moria/usr/share/pixmaps

        rm -f debian/moria.debhelper.log
   debian/rules override_dh_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_install

dh_install: warning: Use of debian/compat is deprecated and will be removed in debhelper (>= 14~).

        install -m0755 -d debian/moria//usr/share/applications

cp --reflink=auto -a ./debian/moria.desktop debian/moria//usr/share/applications/

        install -m0755 -d debian/moria//usr/share/pixmaps

cp --reflink=auto -a ./debian/icons/moria.xpm debian/moria//usr/share/pixmaps/

install -o root -g games -m 2755 umoria/umoria debian/moria/usr/games/moria

install: cannot change ownership of 'debian/moria/usr/games/moria': Operation not permitted

make[1]: *** [debian/rules:15: override_dh_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:5: binary] Error 2

dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

--------------------------------------------------------------------------------
Build finished at 2024-11-17T12:50:51Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1023431.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089392: moria: Supporting rootless builds by default

Reply via email to