Source: mpgtx
Version: 1.3.1-6
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
mpgtx failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
  215 |                 #define   _OFF_d   "%lld"
      |                                     ~~~^
      |                                        |
      |                                        long long int
      |                                     %ld
chunkTab.cxx:559:40: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 4 has type ‘off_t’ {aka ‘long int’} [-Wformat=] 559 | fprintf(stderr,"range %s results in invalid range [" _OFF_d "-" _OFF_d "]\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  560 |                                 boundaries, tc->from, tc->to);
      |                                             ~~~~~~~~
      |                                                 |
| off_t {aka long int}
common.hh:215:40: note: format string is defined here
  215 |                 #define   _OFF_d   "%lld"
      |                                     ~~~^
      |                                        |
      |                                        long long int
      |                                     %ld
chunkTab.cxx:559:40: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 5 has type ‘off_t’ {aka ‘long int’} [-Wformat=] 559 | fprintf(stderr,"range %s results in invalid range [" _OFF_d "-" _OFF_d "]\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  560 |                                 boundaries, tc->from, tc->to);
      |                                                       ~~~~~~
      |                                                           |
| off_t {aka long int}
common.hh:215:40: note: format string is defined here
  215 |                 #define   _OFF_d   "%lld"
      |                                     ~~~^
      |                                        |
      |                                        long long int
      |                                     %ld
chunkTab.cxx: In member function ‘void chunkTab::PrintTab()’:
common.hh:215:36: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 2 has type ‘off_t’ {aka ‘long int’} [-Wformat=]
  215 |                 #define   _OFF_d   "%lld"
      |                                    ^
chunkTab.cxx:583:25: note: in expansion of macro ‘_OFF_d’
583 | printf( _OFF_d "|" _OFF_d , TheTab[i]->from, TheTab[i]->to);
      |                         ^~~~~~
common.hh:215:40: note: format string is defined here
  215 |                 #define   _OFF_d   "%lld"
      |                                     ~~~^
      |                                        |
      |                                        long long int
      |                                     %ld
common.hh:215:36: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 3 has type ‘off_t’ {aka ‘long int’} [-Wformat=]
  215 |                 #define   _OFF_d   "%lld"
      |                                    ^
chunkTab.cxx:583:25: note: in expansion of macro ‘_OFF_d’
583 | printf( _OFF_d "|" _OFF_d , TheTab[i]->from, TheTab[i]->to);
      |                         ^~~~~~
common.hh:215:40: note: format string is defined here
  215 |                 #define   _OFF_d   "%lld"
      |                                     ~~~^
      |                                        |
      |                                        long long int
      |                                     %ld
chunkTab.cxx:592:24: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 5 has type ‘off_t’ {aka ‘long int’} [-Wformat=]
  592 |                 printf("mpeg %.2d : %s [%p](" _OFF_d " bytes)\n",
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
593 | i, MpegTab[i]->Name(), (void*)(MpegTab[i]), MpegTab[i]->Size()); | ~~~~~~~~~~~~~~~~~~ | | | off_t {aka long int}
common.hh:215:40: note: format string is defined here
  215 |                 #define   _OFF_d   "%lld"
      |                                     ~~~^
      |                                        |
      |                                        long long int
      |                                     %ld
g++ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNOSIGNAL_H -O3 -ansi -c id3command.cxx cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
id3command.cxx: In function ‘OpenedFile* OpenFile(char*)’:
id3command.cxx:588:16: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 30 bytes from a string of length 127 [-Wstringop-truncation]
  588 |         strncpy(my->thetag->title,&TAG[3],30);
      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
id3command.cxx:589:16: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 30 bytes from a string of length 127 [-Wstringop-truncation]
  589 |         strncpy(my->thetag->artist,&TAG[33],30);
      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
id3command.cxx:590:16: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 30 bytes from a string of length 127 [-Wstringop-truncation]
  590 |         strncpy(my->thetag->album,&TAG[63],30);
      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
id3command.cxx:591:16: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 4 bytes from a string of length 127 [-Wstringop-truncation]
  591 |         strncpy(my->thetag->year,&TAG[93],4);
      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
id3command.cxx:592:16: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 30 bytes from a string of length 127 [-Wstringop-truncation]
  592 |         strncpy(my->thetag->comment,&TAG[97],30);
      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
id3command.cxx: In function ‘int ParseMov(int, char**, int)’:
id3command.cxx:365:99: warning: ‘sprintf’ may write a terminating nul past the end of the destination [-Wformat-overflow=] 365 | sprintf(temptracknum,"%02d",track); | ^ id3command.cxx:365:80: note: ‘sprintf’ output between 3 and 11 bytes into a destination of size 10 365 | sprintf(temptracknum,"%02d",track); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ g++ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNOSIGNAL_H -O3 -ansi -o mpgtx commandline.cxx mpegOut.o mpeg.o chunkTab.o id3command.o -Wl,-z,relro -s cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
----------------------------------------------------------------------
Success building mpgtx. Now type "make install" to install it
----------------------------------------------------------------------
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
touch build-stamp
dh_testdir
dh_testroot
dh_prep
# Add here commands to install the package into debian/mpgtx.
#/usr/bin/make install DESTDIR=/<<PKGBUILDDIR>>/debian/mpgtx
ln -sf mpgtx mpgjoin
ln -sf mpgtx mpgsplit
ln -sf mpgtx mpgcat
ln -sf mpgtx mpginfo
ln -sf mpgtx mpgdemux
ln -sf mpgtx tagmp3
install -p -d -o root -g root  -m  755 /<<PKGBUILDDIR>>/debian/mpgtx/usr/bin
install: cannot change owner and permissions of ‘/<<PKGBUILDDIR>>/debian/mpgtx/usr/bin’: Operation not permitted
make: *** [debian/rules:87: install] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-11-17T12:59:46Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1023582.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to