Control: tags -1 patch

On Sat, 7 Dec 2024 21:54:06 +0100 Niels Thykier <[email protected]> wrote:
Source: texify
Version: 1.20-4.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
texify failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]


Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

Note: I also included a hint from Multi-Arch hinter, since it was a low hanging fruit.

This package can probably come truly rootless if the upstream makefile could be convinced to not pass `-o root -g root` to `install`. A common trick here is to use `-o $(USER) -g $(GROUP)` and then have the Debian package substitute USER/GROUP with `id -u`/`id -g` (which is a noop but allowed) and then rely on `dh_fixperms` + `dh_builddeb` to build the package with the correct ownership. However, it is was not a minimal patch, so I skipped that for the NMU.

Best regards,
Niels

diff -Nru texify-1.20/debian/changelog texify-1.20/debian/changelog
--- texify-1.20/debian/changelog        2021-01-04 16:07:58.000000000 +0100
+++ texify-1.20/debian/changelog        2025-01-01 11:39:37.000000000 +0100
@@ -1,3 +1,12 @@
+texify (1.20-4.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Make requirement for root when building the package explicit.
+    (Closes: #1089452)
+  * Apply hint from the Multi-Arch hinter.
+
+ -- Niels Thykier <[email protected]>  Wed, 01 Jan 2025 10:39:37 +0000
+
 texify (1.20-4.1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff -Nru texify-1.20/debian/control texify-1.20/debian/control
--- texify-1.20/debian/control  2018-12-13 18:25:02.000000000 +0100
+++ texify-1.20/debian/control  2025-01-01 11:39:37.000000000 +0100
@@ -2,6 +2,7 @@
 Section: utils
 Priority: optional
 Maintainer: Thorsten Alteholz <[email protected]>
+Rules-Requires-Root: binary-targets
 Standards-Version: 4.2.1
 Build-Depends: debhelper (>= 11)
 Vcs-Browser: https://salsa.debian.org/alteholz/texify
@@ -9,6 +10,7 @@
 
 Package: texify
 Architecture: all
+Multi-Arch: foreign
 Depends: ${perl:Depends}, ${misc:Depends}
 Suggests: texlive-base-bin
 Description: Beautify source code for use with LaTeX

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to