Sean Whitton writes ("Bug#1121818: dgit sbuild fails to honour 
--force-orig-source"):
> We could special-case --force-orig-source easily enough,

I don't think that's true.  In order to special case it, we'd need to
parse sbuild's options.  But you can't reliable parse another
program's options because you don't know which arguments are option
values.

In the absence of proper support in dgit, I think --ch:--sa is the
right way to achieve Phil's goal.

Maybe we could write something in the docs?

Philip Hands writes ("Bug#1121818: dgit sbuild fails to honour 
--force-orig-source"):
> That means that I upload basically the same version to unstable,
> stable-backports and stable-fasttrack (apart from trivial changelog
> changes).

I think this is a fine way to carry on.

Back to Sean:

> Thanks.  The build wrapper commands probably have other behaviours which
> only make sense in the context of uploading to Debian.
> 
> [Ideally] we would come up with some overarching mode for building
> for something like fasttrack.  Wanting to use 'dgit sbuild' to build
> binaries for uploading there, in order to ensure the binary packages
> match up to Git, seems like a legitimate use case.

I think it would be best if we could get rid of these build wrappers
entirely.  Avenues to explore:

Currently `dgit push-built` expects to find a built .dsc, along
with binaries.  It *checks* the .dsc and amends it to add the
Dgit:, but it doesn't rebuild it.

The reason we can't just use a .dsc built directly with an unwrapped
sbuild is the .gitignore handling bug in dpkg-source, #908747
(knowledge of which is probably now embedded in in gbp etc.etc.).

If dgit push-built (re)built the source package, then the binary build
(the first of the user's two commands) wouldn't need to build one for
dgit's benefit.  And if it did we could ignore it, or check that the
only discrepancy was in .gitignore.

This does increase the risk that the binaries aren't what gets
uploaded, especialy if dgit push-built doesn't demand that the binary
build did include a source package and check that everything is good
except for .gitignore.

Related, of course, is #868527 which is asking for sbuilt to be able
to build binaries without making a source package at all.

Ian.

-- 
Ian Jackson <[email protected]>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.

Reply via email to