Hello, On Wed 03 Dec 2025 at 11:54am GMT, Ian Jackson wrote:
> Sean Whitton writes ("Bug#1121818: dgit sbuild fails to honour
> --force-orig-source"):
>> We could special-case --force-orig-source easily enough,
>
> I don't think that's true. In order to special case it, we'd need to
> parse sbuild's options. But you can't reliable parse another
> program's options because you don't know which arguments are option
> values.
Well, sbuild is documented to have only one positional argument, so I
think it would be okay in this case.
> I think it would be best if we could get rid of these build wrappers
> entirely. Avenues to explore:
>
> Currently `dgit push-built` expects to find a built .dsc, along
> with binaries. It *checks* the .dsc and amends it to add the
> Dgit:, but it doesn't rebuild it.
>
> The reason we can't just use a .dsc built directly with an unwrapped
> sbuild is the .gitignore handling bug in dpkg-source, #908747
> (knowledge of which is probably now embedded in in gbp etc.etc.).
>
> If dgit push-built (re)built the source package, then the binary build
> (the first of the user's two commands) wouldn't need to build one for
> dgit's benefit. And if it did we could ignore it, or check that the
> only discrepancy was in .gitignore.
>
> This does increase the risk that the binaries aren't what gets
> uploaded, especialy if dgit push-built doesn't demand that the binary
> build did include a source package and check that everything is good
> except for .gitignore.
>
> Related, of course, is #868527 which is asking for sbuilt to be able
> to build binaries without making a source package at all.
Certainly it would be better to get rid of them. It's just that it's
probably a very long way off. But perhaps not so far off that it is
worth something complex to fix this bug, indeed.
--
Sean Whitton
signature.asc
Description: PGP signature
