Source: patroni
Version: 4.1.3-2
Usertags: pidof-without-procps
Dear maintainer(s) of patroni,
it appears that patroni uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of patroni
that use `pidof` at runtime;
* via the `Build-Depends:` field of patroni, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of patroni, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that patroni uses `pidof` due to the following
code snippets:
```
path: patroni_4.1.0-2/features/environment.py
raise Exception
self._wrapper = [docker, 'exec', container]
self._external_pid = subprocess.check_output(self._wrapper +
['pidof', api_process]).decode('utf-8').strip()
return False
return True
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
