Source: ovn Version: 26.03.0-4 Usertags: pidof-without-procps Dear maintainer(s) of ovn,
it appears that ovn uses `pidof` in its testsuite, or that at least one of its binary packages uses `pidof` at runtime. Historically, `pidof` was provided by the Essential package `sysvinit-tools`, making an explicit dependency unnecessary. However `pidof` will soon be moved to `procps` and will no longer be part of the Essential set. Please add an explicit dependency on `procps`: * via the `Depends:` field of all binary packages of ovn that use `pidof` at runtime; * via the `Build-Depends:` field of ovn, if `pidof` is used in tests run at build-time; * via the `Depends:` field of `debian/control/tests`, if `pidof` is used in autopkgtests. To prevent any disruption for users of ovn, please add this dependency now, before `pidof` is moved from `sysvinit-utils` to `procps`. Alternatively, you could remove all uses of `pidof`. It is believed that ovn uses `pidof` due to the following code snippets: ``` path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at ]) kill $(pidof tcpdump) rm -f reject.tcpdump path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at ]) kill $(pidof tcpdump) rm -f *.tcpdump # Now test for IPv6 UDP. path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at NS_CHECK_EXEC([server], [tcpdump -l -nvv -i s1 udp > pkt.pcap 2>tcpdump_err &]) OVS_WAIT_UNTIL([grep "listening" tcpdump_err]) on_exit 'kill $(pidof tcpdump)' NS_CHECK_EXEC([sw01], [dhclient -1 -q -lf $DHCP_TEST_DIR/dhclient-sw01.lease -pf $DHCP_TEST_DIR/dhclient-sw01.pid -cf $DHCP_TEST_DIR/dhclien.conf sw01]) path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at ]) kill $(pidof tcpdump) OVN_CLEANUP_CONTROLLER([hv1]) path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at NETNS_START_TCPDUMP([server], [-nni s1 udp port 3784 -Q in], [bfd]) sleep 5 kill $(pidof tcpdump) AT_CHECK([grep -qi bfd bfd.tcpdump],[1]) path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at ]) kill $(pidof tcpdump) check ovn-nbctl --apply-after-lb acl-add sw1 from-lport 1004 "ip" allow-related path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at AS_BOX([initial ping]) # Send ping in background. Same ping, same flow throughout the test on_exit 'kill $(pidof ping)' NS_EXEC([vm1], [ping -c 10000 -i 0.1 30.0.0.1 > icmp.txt &]) path: ovn_26.03.0~git20260216.b543a88-4/tests/system-ovn.at NS_CHECK_EXEC([server], [tcpdump -l -nvv -i s1 icmp > pkt.pcap 2>tcpdump_err &]) OVS_WAIT_UNTIL([grep "listening" tcpdump_err]) on_exit 'kill $(pidof tcpdump)' NS_CHECK_EXEC([sw01], [ping -q -c 2 -i 0.2 -w 2 172.16.1.1 | FORMAT_PING], ``` Feel free to close this issue if this is a false positive (for example if this code is in an unreachable code path). Regards, -- Gioele Barabucci
