Source: php-defaults
Version: 99
Usertags: pidof-without-procps
Dear maintainer(s) of php-defaults,
it appears that php-defaults uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of php-defaults
that use `pidof` at runtime;
* via the `Build-Depends:` field of php-defaults, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of php-defaults, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that php-defaults uses `pidof` due to the following
code snippets:
```
path: php-defaults_99/sessionclean
done
# first find all open session files and touch them (hope it's not massive
amount of files)
for pid in $(pidof $proc_names); do
find "/proc/$pid/fd" -ignore_readdir_race -lname "$save_path/sess_*" -exec
touch -c {} \; 2>/dev/null
done ) | \
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
