On Monday, 17.07.2006 at 15:30 +0200, Adam Borowski wrote: > Hello. If the output is not a terminal (like, when using diff to make a > patch), colordiff will still happily colorize the output. This is bad if > "diff" is an alias to "colordiff", as suggested in the manpage.
That's a very good point :-) > The fix is simple: > > exec "/usr/bin/diff",@ARGV unless -t STDOUT; It's unclear to me exactly what you're suggesting: are you suggesting an alternative means of aliasing 'diff', or is the above a modification to the code? I'd find it helpful if you could turn the above into a patch, thanks. > I already reported this bug upstream over three years ago, but it > appears to be left unfixed. At least, the bug bit me today again :p [Odd - I've got no record of you ever contacting me, which is strange since I'm usually fairly obsessive about keeping that sort of email. Did I ever reply?! Apologies if not, but I don't think I got your message.] I'll get this fixed now though, if you can clarify the nature of your fix above. Thanks, Dave. -- Dave Ewart - [EMAIL PROTECTED] - jabber: [EMAIL PROTECTED] - freenode: davee All email from me is now digitally signed, key from http://www.sungate.co.uk/ Fingerprint: AEC5 9360 0A35 7F66 66E9 82E4 9E10 6769 CD28 DA92
signature.asc
Description: Digital signature
