Package: libhtml-mason-perl
Version: 1:1.35-3
Severity: normal
Tags: patch

HTML::Mason::Request::CGI subclasses HTML::Mason::Request to add
additional CGI functionality.  Among other things, it overrides the
'exec' method, performing CGI-related actions based on the return
value of the underlying standard 'exec' call.

What it then fails to do is to eventually pass on the return value
of the underlying 'exec' call.  This causes problems for anything
that relies on the return value of a Mason template -- code that
works in mod_perl or in a standalone manner will mysteriously fail
in a CGI context.

I've included a patch to resolve this omission.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (400, 'testing'), (300, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.16-2-686
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libhtml-mason-perl depends on:
ii  libcache-cache-perl           1.05-2     Managed caches of persistent infor
ii  libclass-container-perl       0.12-2     Glues object frameworks together t
ii  libexception-class-perl       1.23-1     a module that allows you to declar
ii  libparams-validate-perl       0.77-1     validate parameters to Perl method
ii  perl                          5.8.8-7    Larry Wall's Practical Extraction 
ii  perl-base [libscalar-list-uti 5.8.8-7    The Pathologically Eclectic Rubbis

Versions of packages libhtml-mason-perl recommends:
ii  libapache-mod-perl          1.29.0.4-4.1 integration of perl with the Apach
ii  libapache-request-perl      1.33-1       Generic Apache Request Library
ii  libapache2-mod-perl2        2.0.2-2.4    Integration of perl with the Apach

-- no debconf information
Thu May 24 19:14:03 EDT 2007  Adrian Irving-Beer <[EMAIL PROTECTED]>
  * Return SUPER::exec return value in CGI 'exec' method.
diff -rN -u old-libhtml-mason-perl-1.35/lib/HTML/Mason/CGIHandler.pm new-libhtml-mason-perl-1.35/lib/HTML/Mason/CGIHandler.pm
--- old-libhtml-mason-perl-1.35/lib/HTML/Mason/CGIHandler.pm	2007-05-24 19:18:55.098774801 -0400
+++ new-libhtml-mason-perl-1.35/lib/HTML/Mason/CGIHandler.pm	2007-05-24 19:18:55.130775815 -0400
@@ -207,6 +207,8 @@
         and (!$retval or $retval==200)) {
         $r->send_http_header();
     }
+
+    return $retval;
 }
 
 sub redirect {

Attachment: signature.asc
Description: Digital signature

Reply via email to