Package: mutt Version: 1.5.17+20080114-1.pgpsigdispattach1 Severity: normal Tags: patch
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I believe that mutt is incorrectly assigning the Content-Disposition of PGP/MIME signature attachments as "inline". This causes some MUAs (eg. gmail) to feel the need to display the attached signature inline, instead of as an attachment. I believe that the Content-Disposition should instead be set to "attachment", since that is in fact what it is. I notice, though, that the Content-Disposition is specifically hard coded in the mutt pgp.c source to be "DISPINLINE" instead of "DISPATTACH". I wonder why this is, since it appears to be a deliberate choice. This seems wrong to me, but I would be curious to hear a justification. I am including a patch that changes the Content-Disposition for PGP/MIME signatures to be DISPATTACH instead of DISPINLINE. This patch has been tested and working in the lenny version of mutt I am currently using. If there is reasonable justification for keeping the default to be DISPINLINE, then I think we should make a patch where the value of the Content-Disposition is set by a mutt variable, therefore allowing users to easily change it if need be. Thanks so much for maintaining such a great MUA. Let me know if I can be of any further help. jamie. - -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (500, 'testing'), (200, 'unstable'), (101, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages mutt depends on: ii libc6 2.7-6 GNU C Library: Shared libraries ii libgdbm3 1.8.3-3 GNU dbm database routines (runtime ii libgnutls26 2.2.1-3 the GNU TLS library - runtime libr ii libidn11 1.1-1 GNU libidn library, implementation ii libncursesw5 5.6+20080119-1 Shared libraries for terminal hand ii libsasl2-2 2.1.22.dfsg1-16 Cyrus SASL - authentication abstra Versions of packages mutt recommends: ii exim4-daemon-light [mail-tran 4.69-2 lightweight Exim MTA (v4) daemon ii locales 2.7-6 GNU C Library: National Language ( ii mime-support 3.39-1 MIME files 'mime.types' & 'mailcap - -- no debconf information -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUBR7tPQ+00zqvie6q8AQLEFg//U9KJjqTrhqjyaK6SBC02VMr1+tt3vHSc QAB6TTGGAtPc42kBnAmQxPqgIbIjPg0/DyP9JcudamAn56uCffhwm5lPfRsOW75i rfr4fGvnY9BZFNsAroQ/+AJ1jwQjf3E6kuiAQgpncYsxggRYIy/PVIgpe3t86WU+ vT8Xfg4kIRE/cEM33lPJTu7uwW9T+tonAA4MJ4tOG6HZEJLzs5Z5vlN6mc0MCY08 97bNj0gnZSXTPHs+A305TSpEr5i/EfKYVT9HMGEkbV47hiDSOOQcMSHd2ztLaC1z S5nJ5uqXy+2hQytMbItc3Hp256zG7oV33AJLd8GU+HMr5oe7ZaTtH6pcLbR4sVDL 1SHWP2/FMEoBoX2gVBrV5qohnx2S2NPipHYTsBaU1dqMpwPi1PoQ9y98AuO09GNE xc/RbeO0lbFc/KeI2Dbd7jBbnry0pozP+SGORld5I6ttNMDTCTm0bqxM11s/T7Om grdvzEIVkIpmfeIEq4454zgGC5ESwB0oC3fqkh1jSlVn7mvPkbCweffUUtVQks81 5/lksDCxH3Ak6bIMBs4tVOPCe8clJ/JRW/qbtty5ckbSmj/X9Ba+gFKbwZPHsWBP Up/712j2RMXLjiKbdUlMpUdflePUFZnSGbSJUr4IeLHmXGICSR1VA476nYzh7PiY sGT1nTfz/vo= =RxwH -----END PGP SIGNATURE-----
--- pgp.c.orig 2008-02-19 10:41:03.000000000 -0500 +++ pgp.c 2008-02-18 23:58:57.000000000 -0500 @@ -1105,7 +1105,7 @@ t->subtype = safe_strdup ("pgp-signature"); t->filename = safe_strdup (sigfile); t->use_disp = 0; - t->disposition = DISPINLINE; + t->disposition = DISPATTACH; t->encoding = ENC7BIT; t->unlink = 1; /* ok to remove this file after sending. */ mutt_set_parameter ("name", PgpMimeSignatureFilename, &t->parameter);