* Joerg Schilling <[EMAIL PROTECTED]> [20080414 23:11]:

> I recommend to through away the sources at http://hg.svartech.com/debian/star/
> and cleanly start with the official source.

> The reason for a clean start is:

> 1)    your source includes a broken star_fat.c, but it sould not
>       contain this file at all. Seeing star_fat.c makes me asume that
>       there might be other problems that are best handled by a clean 
>       new setup.

> 2)    The source has been cleaned up past 1.5a89 to only use a clean
>       libfind. If you do not start cleanly, you will most likely keep
>       outdated files.

> 3)    you should get help from Mika for the correct make wrapper from
>       cdrtools that uses the right values for INS_BASE= and DESTDIR=

Yes, I'd propose to start with no additional patches applied at all.
A short shot (may include some false positives though) gives me:

% diff -urN star-1.5 star.debian 2>/dev/null | grep '^+++' | wc -l
183

debian/rules should receive a general cleanup as well.
Pawel - what do you think about (re-)starting from (nearly) scratch?
IMHO we should use debian/patches/ (dpatch, quilt,... - whatever you
prefer) instead of directly patching upstream sources as well.

regards,
-mika-

Attachment: signature.asc
Description: Digital signature

Reply via email to