reopen 475732 retitle 475732 libfishsound has a broken test for the speex version severity 475732 important thanks
Hi, The fix currently applied to close this bug is a fairly blunt workaround for a broken autoconf test, namely this one: AC_CHECK_HEADER([speex/speex_preprocess.h], HAVE_SPEEX_1_1="yes" Which in conjunction with the test for HAVE_SPEEX_1_1 in src/libfishsound/speex.c, results in the code looking for headers in the speex1.0 locations, when using speex1.2 and later that have split the speexdsp functions into a separate library. Since libfishsound doesn't appear to use speex_preprocess.h or any of the other speexdsp functions, it would be better to just test for speex/speex.h instead, since it is the location of that header that this test is being used to conditionally select anyhow. When that is fixed, the patch that closed this bug (adding an extra search path to CFLAGS) should likewise be reverted. Please forward this to the upstream maintainers if they aren't aware of it already. If they are, we should get a fixed version into the archive before this freezes for Lenny ... Cheers, Ron -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
