Hi Cesare,
I'm very sorry for this long delay answering to this bug report, I'm
quitting from a long period of too much troubles...

I've looked at the source and at the .dsc of the package uploaded to
debian, I don't know where I've made the mistake, but there is a
difference from the patch in my svn repository and the patch in the .dsc
uploaded to debian repository. In the last uploaded package I've put a
wrong patch, different from the one suggested to the upstream author...
Shame on me for this error... I think that I've work on a outdated
version of the package in my notebook...

Now I'm working to solve this bug, and to upload a correct version to
the repositories...

I've seen that your package in ubuntu has been uploaded with the right
patch... So in your side the problem is solved.

Thanks very much for the report and for your collaboration.

Best wishes,
francesco

Il giorno sab, 03/05/2008 alle 21.50 +0200, Cesare Tirabassi ha scritto:
> Hi Francesco,
> 
> it seems that your patch in 1.7-5 is not the same as the one you have given 
> to 
> gnomeradio upstream?
> 
> Patch in 1.7-5:
> 
> diff -Nur gnomeradio-1.7/src/prefs.c gnomeradio-1.7.new/src/prefs.c
> --- gnomeradio-1.7/src/prefs.c        2006-11-25 12:33:57.000000000 +0100
> +++ gnomeradio-1.7.new/src/prefs.c    2008-02-05 22:34:47.000000000 +0100
> @@ -415,6 +415,7 @@
>       
>       menuitems = GTK_MENU_SHELL(tray_menu)->children;
>       g_assert(mom_ps < g_list_length(menuitems));
> +        mom_ps = *row;
>       menuitem = g_list_nth_data(menuitems, mom_ps);
>       gtk_widget_destroy(menuitem);
>       menuitem = gtk_menu_item_new_with_label(ps->title);
> 
> Patch from http://bugzilla.gnome.org/attachment.cgi?id=104558:
> 
> diff -Nur gnomeradio-1.7/src/prefs.c gnomeradio-1.7.new/src/prefs.c
> --- gnomeradio-1.7/src/prefs.c        2006-11-25 12:33:57.000000000 +0100
> +++ gnomeradio-1.7.new/src/prefs.c    2008-02-05 23:11:32.000000000 +0100
> @@ -411,7 +411,8 @@
>  
>       gtk_combo_box_remove_text(GTK_COMBO_BOX(preset_combo), *row + 1);
>       gtk_combo_box_insert_text(GTK_COMBO_BOX(preset_combo), *row + 1, 
> ps->title);
> -     preset_combo_set_item(mom_ps);
> +        mom_ps = *row;
> +        preset_combo_set_item(mom_ps);
>       
>       menuitems = GTK_MENU_SHELL(tray_menu)->children;
>       g_assert(mom_ps < g_list_length(menuitems));
> 
> The former doesn't seem to be working but the latter does indeed fix the 
> crash.
> 
> Cesare
-- 
Francesco Namuri
francesco(at)namuri(dot)it   http://namuri.it/
id gpg key: 21A4702A         [EMAIL PROTECTED]

Attachment: signature.asc
Description: Questa รจ una parte del messaggio firmata digitalmente

Reply via email to