clone 483442 -1
reassign -1 perl 5.10.0-10
retitle -1 -x is broken with 'use filetest q/access/'
severity -1 important
tag -1 = patch fixed-upstream
submitter -1 !
thanks
On Fri, May 30, 2008 at 11:16:27PM +0300, Niko Tyni wrote:
> On Thu, May 29, 2008 at 04:31:11PM +0200, Daniel Leidert wrote:
>
> > A user reported an issue with cvsweb in http://bugs.debian.org/483442. I
> > was able to track it down to be in search_path(). This function takes a
> > command as argument and tries with a list of paths, if $path/$command is
> > executable (-x) and not a directory (!-d).
> >
> > Now this test fails with Perl 5.10, although cvsweb has all-executable
> > permissions. Anybody an idea, why this fails? Using -X instead of -x
> > seems to work for the moment. But testing on the effective uid/gid IMHO
> > is the correct choice here.
>
> This is <http://rt.perl.org/rt3/Public/Bug/Display.html?id=49003>,
> fixed upstream after 5.10.0. It only happens with 'use filetest
> qw(access)'. Looks like we'll have to backport the fix, I'll clone
> the bug to track that.
Here we go. Patch from upstream change 32874 attached.
--
Niko Tyni [EMAIL PROTECTED]
diff --git a/pp_sys.c b/pp_sys.c
index 66ca0fb..da07e46 100644
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -2999,10 +2999,9 @@ PP(pp_ftrread)
effective = TRUE;
break;
-
case OP_FTEEXEC:
#ifdef PERL_EFF_ACCESS
- access_mode = W_OK;
+ access_mode = X_OK;
#else
use_access = 0;
#endif
