Oops, I sent the message to the wrong bug, initially.
---------- Forwarded message ---------- From: Eddy Petrișor <[EMAIL PROTECTED]> Date: 2008/11/25 Subject: Re: r11871 - in /deb-maint/svn-buildpackage/trunk: SDCommon.pm debian/changelog To: Jan Hauke Rahm <[EMAIL PROTECTED]>, [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] 2008/11/25 <[EMAIL PROTECTED]>: > Author: jhr-guest > Date: Tue Nov 25 08:26:26 2008 > New Revision: 11871 > > URL: http://svn.debian.org/wsvn/collab-maint/?sc=1&rev=11871 > Log: > svn-buildpackage: SDCommon.pm: Trigger a warning when files are ignored by > subversion (Closes: #504233) > > Modified: > deb-maint/svn-buildpackage/trunk/SDCommon.pm > deb-maint/svn-buildpackage/trunk/debian/changelog > > Modified: deb-maint/svn-buildpackage/trunk/SDCommon.pm > URL: > http://svn.debian.org/wsvn/collab-maint/deb-maint/svn-buildpackage/trunk/SDCommon.pm?rev=11871&op=diff > ============================================================================== > --- deb-maint/svn-buildpackage/trunk/SDCommon.pm (original) > +++ deb-maint/svn-buildpackage/trunk/SDCommon.pm Tue Nov 25 08:26:26 2008 > @@ -578,8 +578,19 @@ > for(keys %tmp) { > if($tmp{$_} == 2) { > $ctx->add($_, 1); > + } elsif($tmp{$_} == 11) { # subversion ignores some files, like > .swp from vim; see #504233 for details > + print STDERR "One or more files are ignore due to global > subversion ignore patterns,\n\tquit the process here? [y/n?]: "; This is not OK, since it breaks noninteractive builders. It should use some form of withEcho or something simillar in order to take into account the noninteractive option. This should be a warning, not a fatal error, thus... > + prompt: > + my $ans = <STDIN>; > + if($ans !~ /^[yn]/i) { > + print STDERR "The choices are:\n\tYes (y) which means > aborting, or No (n) which means to NOT include those files.\n"; the default should be to go on with the ignored pattern, not to quit. > + goto prompt; > + } > + if($ans =~ /^y$/i) { > + exwerror("Aborting.\n"); > + } > } > - } > + } > chdir $curdir; > } Another solution would be to simply use "svn add --no-igore" with all the files found in the filesystem. -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein
