On Wed, Aug 19, 2009 at 01:56:32PM +0200, Werner Fink wrote:
> On Wed, Aug 19, 2009 at 01:45:36PM +0200, Michael Meskes wrote:
> > On Wed, Aug 19, 2009 at 12:27:34PM +0200, Dr. Werner Fink wrote:
> > > On Wed, Aug 19, 2009 at 12:10:16PM +0200, Michael Meskes wrote:
> > > > I'm sorry, my last report was incorrect. I only checked runlevel 1 for
> > > > which
> > > > the links were okay. In 0 and 6 however I still have alsa-utils,
> > > > cryptdisks,
> > > > fuse, urandom and wpa-ifdown in K01 although none of them uses $all.
> > >
> > > Hmmm ... if the script using $all is not within the same runlevels
> > > this may happens but should not hurt. The topological sort is only
> > > applied if the scripts/services uses the same runlevels. This is
> > > done by bit masks were each bit is representing a specific runlevel.
> >
> > Seems I wasn't precise enough. Of course I also have K01watchdog in levels 0
> > and 6. Watchdog's init script has:
> >
> > # Required-Stop: $all
> >
> > AFAICT this should make watchdog the only script in K01, wouldn't it?
>
> Yep ... please try out the attached patch.
>
> Werner
>
> --
> "Having a smoking section in a restaurant is like having
> a peeing section in a swimming pool." -- Edward Burr
> --- insserv.c
> +++ insserv.c 2009-08-19 13:54:39.694401388 +0200
> @@ -653,7 +653,7 @@ static inline void all_script(void)
> if (cur->attr.flags & SERV_DUPLET)
> continue; /* Duplet */
>
> - if ((serv->start->lvl & cur->start->lvl) == 0)
> + if ((serv->stopp->lvl & cur->stopp->lvl) == 0)
> continue;
>
> if (cur == serv)
The patch is for a test 1.13.0 ... the affected line is in
first_script(void) in your version and not in all_script(void).
Werner
--
"Having a smoking section in a restaurant is like having
a peeing section in a swimming pool." -- Edward Burr
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
