Eddy Petrisor wrote:
Subject: apt-zip: lacks space validation relative path support
Package: apt-zip
Version: 0.13.2
Severity: normal
Tags: patch

Hello,
I have made some improvements to the apt-zip package:

diff -ruN apt-zip-0.13.2/debian/changelog apt-zip-0.13.3/debian/changelog
--- apt-zip-0.13.2/debian/changelog     2001-11-02 11:35:13.000000000 +0200
+++ apt-zip-0.13.3/debian/changelog     2005-07-24 00:13:06.000000000 +0300
@@ -1,7 +1,19 @@
+apt-zip (0.13.3) unstable; urgency=low
+
+  * paths containing spaces are now supported
+  * generator and fetch scripts are now nicely indented and more readable
+  * relative paths for mount points are now supported
+  * display download size after generation and before download
+  * replaced file tests based on which with tests based on type
+  * replaced tabs with spaces in the changelog, where appropriate
+  * Updated the apt-zip.copyright file
+
+ -- Eddy Petrișor <[EMAIL PROTECTED]>  Sat, 23 Jul 2005 23:10:01 +0300
+
 apt-zip (0.13.2) unstable; urgency=low

   * build dependence: replaced obsolete doocbook2man with the newer


The attached patch creates from a apt-zip-0.13.2 source package, a
source package for version 0.13.3 and fixes the problems listed.

I hope somebody will have the time to maintain this package (or at
least orphan it) as I have seen three other patches in BTS

I'm checking your patch.

Why you do such changes ?
-[ -z "$APTGETACTION" -a -z "$PACKAGES" ] &&
+[ -z "$APTGETACTION" -a -z "${PACKAGES}" ] &&


in methods/wget you did some changes:
- type instead of which
- <<-EOF instead of <<EOF

Why did you make such changes?
You should change methods/wget very carefully. This script should
run in a lot of different system, so I should be sure that solve a problem
and that it run in most of old unixes.
BTW you tested your patch outside Debian?

If you want to help maintaining the package, I will appreciate!
I've a lot of stuff to integrate to apt-zip (so that it can be usefull also
for testing and sid), but not yet integrated.
I've some problem maintainig the old interface but in the same time enhancing
a lot the capabilities of scripts. At the end I want a method that work also
on windows.

ciao
        cate





Reply via email to