Roy Marples wrote: I have the dhcpcd5 package installed and running. It seems to be behaving itself and looks like a good start.
Some observations of things that should be looked at. . The source package should be dhcpcd5, not dhcpcd, since the existing source package is dhcpcd . The initscript sources /etc/default/dhcpcd, but it doesn't define or use any variables. At very least there should be an ENABLED flag, and a distributed default file which leaves that disabled. Should it be possible to restrict the set of interfaces here too? I'm not clear if that can be done in /etc/dhcpcd.conf . Coexistence with dhcpcd3 The following files are in both dhcpcd and dhcpcd5 /etc/default/dhcpcd /usr/share/man/man8/dhcpcd.8.gz /sbin/dhcpcd dhcpcd5 conflicts with dhcpcd, so the man page and binary are OK, but the default file isn't, since it's a config file that could be left even after dhcpcd has been removed. It should probably be /etc/default/dhcpcd5 It's worth thinking about designing dhcpcd5 so that it doesn't conflict with dhcpcd. Since taking a working system with dhcpcd and installing dhcpcd5 isn't going to keep it working by having dhpcd5 take over, making installation of dhcpcd5 cause removal of dhcpcd looks unfriendly. The other DHCP clients in Debian can be installed simultaneously, I think. The simplest way to do that would be to make the binary /sbin/dhcpcd5 and the man page similarly. NOte that if /sbin/dhcpcd exists, it's going to be called by ifup. If it doesn't accept the flags that ifup provides and work compatibly under those circumstances, then it needs to be called something else. The preinst removal of files left by dhcpcd is wrong, a package should not touch files belonging to a different package. Cheers, Simon. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
