Bug#587444: procmail vacation script without start or end date eats all mail

[Gaudenz Steinlin]

Package: ingo1
Version: 1.2.3+debian0-1
Severity: important
Tags: patch

The procmail script generated by the ingo vacation part eats all incomming 
mails if no start or end date is specified. The scripts generates vacation 
messages,
but does not store the mail in the inbox. If a start or end date is specified 
then
problematic part is wraped in another block wich ensures that the vacation 
script 
operates on a copy of the mail. The attached patch adds this block even if no 
start
or stop date is specified.

IMHO this is a pretty serious issue because users may loose all incomming 
mails. If you 
disagree feel free to set the severity to normal.

Gaudenz

-- System Information:
Debian Release: 5.0.5
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.26-2-amd64 (SMP w/1 CPU core)
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages ingo1 depends on:
ii  horde3            3.2.2+debian0-2+lenny2 horde web application framework

Versions of packages ingo1 recommends:
ii  php5-imap          5.2.6.dfsg.1-1+lenny8 IMAP module for php5

Versions of packages ingo1 suggests:
ii  imp4                          4.2-4      webmail component for horde framew
pn  php-net-sieve                 <none>     (no description available)

-- no debconf information

--- procmail.php.orig   2010-06-28 16:07:50.047525988 +0200
+++ procmail.php        2010-06-28 16:14:57.610422041 +0200
@@ -491,9 +491,9 @@
                     $this->_action[] = '    :0 Whc: 
${VACATION_DIR:-.}/vacation.lock';
                     if ($timed) {
                         $this->_action[] = '    * ? test $DATE -gt $START && 
test $END -gt $DATE';
-                       $this->_action[] = '    {';
-                        $this->_action[] = '      :0 Wh';
                     }
+                   $this->_action[] = '    {';
+                    $this->_action[] = '      :0 Wh';
                     $this->_action[] = '      * ^TO_' . $address;
                     $this->_action[] = '      * !^X-Loop: ' . $address;
                     $this->_action[] = '      * !^X-Spam-Flag: YES';
@@ -524,9 +524,7 @@
                     $reason = addcslashes($reason, "\\\n\r\t\"`");
                     $this->_action[] = '       ' . $this->_params['echo'] . ' 
-e "' . $reason . '" \\';
                     $this->_action[] = '      ) | $SENDMAIL -f' . $address . ' 
-oi -t';
-                    if ($timed) {
-                        $this->_action[] = '    }';
-                    }
+                    $this->_action[] = '    }';
                     $this->_action[] = '  }';
                 }
             }