Bug#608624: testparm.samba3: unexplained warning "rlimit_max: rlimit_max (1024) below minimum Windows limit (16384)"

[Steve Langasek]

On Sun, Jan 02, 2011 at 02:40:09AM -0600, Jonathan Nieder wrote:

> diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
> index 2f68f00..bda20d8 100644
> --- a/source3/param/loadparm.c
> +++ b/source3/param/loadparm.c
> @@ -4898,7 +4898,7 @@ static int max_open_files(void)
>  #endif
>  
>       if (sysctl_max < MIN_OPEN_FILES_WINDOWS) {
> -             DEBUG(2,("max_open_files: sysctl_max (%d) below "
> +             DEBUG(2,("max_open_files: increasing sysctl_max (%d) to "
>                       "minimum Windows limit (%d)\n",
>                       sysctl_max,
>                       MIN_OPEN_FILES_WINDOWS));
> @@ -4906,7 +4906,7 @@ static int max_open_files(void)
>       }
>  
>       if (rlimit_max < MIN_OPEN_FILES_WINDOWS) {
> -             DEBUG(2,("rlimit_max: rlimit_max (%d) below "
> +             DEBUG(2,("rlimit_max: increasing rlimit_max (%d) to "
>                       "minimum Windows limit (%d)\n",
>                       rlimit_max,
>                       MIN_OPEN_FILES_WINDOWS));
> -- 
> 1.7.4.rc0

At minimum, the debug message should be cleaned up to state *what* rlimit is
too low; the current message mentions nothing about file descriptors.

Otherwise, I'm not overly concerned about this.  Nowadays, the default log
level is '0', isn't it?  So only users who have manually adjusted the
smb.conf 'log level' setting would be seeing this warning.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org

signature.asc
Description: Digital signature