On Mon, Jan 17, 2011 at 10:27:10PM -0600, Jonathan Nieder wrote:
> Package: git-buildpackage
> Version: 0.5.17
> Tags: patch
>
> Hi again,
>
> Currently git import-dsc sets the committer date on commits it writes
> to equal the author date. That means it is very easy to get
> out-of-order commit timestamps, which are a bad thing™. [1]
>
> But more important to me is the following:
>
> Suppose Bob makes a repo based on the Debian revision history of
> pkg, in 2002.
>
> Independently, Alice makes such a repo in 2007.
>
> Naturally, the two repos are unlikely to be identical ---
> details of tools might have changed, they might track upstream
> history in a different way, and some intermediate Debian revs
> might have been unearthed or lost to time.
>
> Now I look at these two repos and see some discrepancies and
> would like to figure out what happen.
>
> In other words, to my taste the date committed to git is worth
> remembering. What do you think?
>
> Of course it might also be easy to convince me otherwise. :)
I tend to agree here. I introduced the change recently since Rob (cc:)
had good arguments for it:
# However, the committer date does appear to affect things like the
# --since and --until arguments, and if you're trying to import old
# history, I think you might really want both dates to be set to the
# correct historical time.
# In fact, it looks like that's what some of the conversion tools do
# (judging from the converted upstream guile archive). They set both
# dates.
I'm o.k. with reverting this change since I thing setting the committer
date to the date the commit to git happened is the right thing to do but
I wanted to get you two in touch exchange arguments I might be missing.
It's probably best to add two new options:
--author-is-committer
and
--author-date-is-committer-date
so everybody can have this as he wants to (although I hoped this would
not be necessary).
Cheers,
-- Guido
>
> Regards,
> Jonathan
>
> [1] http://article.gmane.org/gmane.comp.version-control.git/145544
>
> diff --git a/git-import-dsc b/git-import-dsc
> index 0c56eda..409e345 100755
> --- a/git-import-dsc
> +++ b/git-import-dsc
> @@ -109,8 +109,7 @@ def apply_debian_patch(repo, unpack_dir, src, options,
> parents):
> other_parents = parents,
> author = author,
> email = email,
> - date = date,
> - commit_date = date)
> + date = date)
> gitTag(build_tag(options.debian_tag, version),
> msg="Debian release %s" % version, commit=commit)
> except gbpc.CommandExecFailed:
>
>
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
