Hi!

* Andreas Stempfhuber <[EMAIL PROTECTED]> [2008-10-04 19:51:09 CEST]:
> the Commodore ROM images are part of the source and binary packages in SID 
> and 
> Lenny. Etch is only partly affected, it contains the ROM images 
> data/PET/basic2, data/PRINTER/cbm1526, data/PRINTER/mps801 and 
> data/PRINTER/mps803.

 Ouch, you are completely right ...

> Regarding to the copyright, control, README.Debian and README.ROMs files this 
> should not be the case due to copyright issues.

 Exactly.

> Additional notes:
> 
> 1) There is a romtest included in the debian/rules files which should AFAIK 
> prevent building the package with ROM images, but the romtest is 
> unfortunately not called during the build procedure e.g. with 
> dpkg-buildpackage.

 Thanks for the notice.

> 2) AFAIK the mangle-source.sh script should remove the ROM images prior to 
> build by overwriting them with dummy entries. This works however not for 
> data/PRINTER/mps803.

 The file is exactly 3.5k in size, the mangle-source.sh (which contains
bashism but starts with #!/bin/sh - another issue) only checks for
multiples of 2k

> 3) The debian/rules script contains the following:
> 
> #       Remove the 0-byte placeholders
>         cd debian/$(PACKAGE)/usr/lib/vice && find . -empty -exec rm {} \;
> 
> which should AFAIK remove the placeholders made with the mangle-source.sh 
> script. This does unfortunately also not work since the placeholders 
> containing 6 bytes and are not empty. As a result the dummy ROM images are 
> included in the .deb file and during installation valid ROM images are 
> overwritten with the dummy files.

 Great, another super catch. Replacing -empty with -size 6c should work
here.

 I am willing to do an NMU for fixing this, it would be a pity if vice
would get dropped.

 When I get the patch ready I'll followup to this bugreport.

 So long,
Rhonda



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to