On Sat, Sep 24, 2005 at 09:27:22PM -0400, John David Anglin wrote:
> The last "fic" opcode entry is wrong.  It's using the wrong
> instruction format, the mask is wrong, pa10 is wrong, etc.

I don't think we realised this until now.  I suspect we've been
silently emitting bad code up until this point, and given that it's
in flush_kernel_icache_page, maybe it explains some of our occasional
crashes.

The code was previously:

        fic,m           %r23(%r26)

We're trying to flush kernel space at this point, so we can use any of
sr4-sr7.   I suspect before we were putting sr0 in, which could have
been flushing any random space instead of the one we wanted.  I'll
commit this change to the kernel source now.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to