Control: tag -1 + patch

On Sun, 21 Oct 2012 12:11:26 +0200, Holger Levsen wrote:

> On Freitag, 19. Oktober 2012, Peter Eisentraut wrote:
> > I think this bug should be made release-critical, because it breaks the
> > package's configuration during a routine upgrade.
> 
> raising the severity until I'm sure I disagree.
> (little time atm, $life and dc13 preparations once again...)

If I understand it correctly, the problem arises from:
- the old postrm removed the symlink unconditionally
  (the new one does this only during purge)
- the new postinst creates the symlink only for fresh installs

Possible solutions:
1) (re-)create the symlink unconditionally (→ attached patch)
2) create it on new installs or if $prevver <= $version_that_changes_the_scripts


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Tom Waits: Hang On St. Christopher
diff -u munin-2.0.6/debian/changelog munin-2.0.6/debian/changelog
--- munin-2.0.6/debian/changelog
+++ munin-2.0.6/debian/changelog
@@ -1,3 +1,14 @@
+munin (2.0.6-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Fix "/etc/apache2/conf.d/munin removed on upgrade":
+    - debian/munin.postinst: always (re-)create symlink, not only on new
+      installs (unfortunately old versions of the postrm unconditionally
+      removed the symlink).
+    (Closes: #677943)
+
+ -- gregor herrmann <gre...@debian.org>  Sun, 21 Oct 2012 16:27:43 +0200
+
 munin (2.0.6-1) unstable; urgency=high
 
   * New upstream release 2.0.6, switching back to cron graphing (as it better
diff -u munin-2.0.6/debian/munin.postinst munin-2.0.6/debian/munin.postinst
--- munin-2.0.6/debian/munin.postinst
+++ munin-2.0.6/debian/munin.postinst
@@ -63,10 +63,7 @@
         webserver=apache2
         webserver_init_script="/etc/init.d/$webserver"
         if [ -d /etc/$webserver/conf.d ] && [ ! -e /etc/$webserver/conf.d/munin ]; then
-		if [ -z "$prevver" ] ; then
-			# only create link on new installs
-	                ln -s ../../munin/apache.conf /etc/$webserver/conf.d/munin
-		fi
+	        ln -sf ../../munin/apache.conf /etc/$webserver/conf.d/munin
 		if [ -f $webserver_init_script ];then
 			if [ -x $webserver_init_script ]; then
 				invoke-rc.d $webserver reload 3>/dev/null || true

Attachment: signature.asc
Description: Digital signature

Reply via email to