On So, 2013-09-22 at 14:52 +0200, Sebastian Ramacher wrote:
> On 2013-09-13 09:16:35, Sebastian Dröge wrote:
> > On Fr, 2013-09-13 at 02:56 +0200, Sebastian Ramacher wrote:
> > > On 2013-09-12 14:00:43, Sebastian Dröge wrote:
> > > > On Do, 2013-09-12 at 12:57 +0200, Sebastian Ramacher wrote:
> > > > > On 2013-09-09 20:53:03, Luk Claes wrote:
> > > > > > >> Can/should this be removed in favour of gst-libav1.0?
> > > > > > >
> > > > > > > Yes it should probably be just removed. I plan to get rid of all 
> > > > > > > of
> > > > > > > gstreamer 0.10 in the next months, so let's just let this one go 
> > > > > > > now
> > > > > > > already :)
> > > > > > 
> > > > > > testing removal hint added.
> > > > > 
> > > > > That didn't work - there are reverse dependencies. Seems like
> > > > > gstreamer0.10-ffmpeg needs to be fixed.
> > > > 
> > > > The rdepends should be ported to GStreamer 1.0 instead probably. Also
> > > > most of these rdepends should at most Recommend the package.
> > > 
> > > Sure, ideally they would be ported to use GStreamer 1.0 instead. But I'd
> > > rather not add yet another transition on top of the libav transition.
> > > 
> > > I've started to backport the necessary changes for libav 9 from
> > > gst-libav1.0. I'm at a state where it compiles and appreciate another
> > > pair of eyes looking over it as the patch got really large.
> > 
> > From skipping over it this patch looks good, you only remove support for
> > paletted video formats and also some more changes are necessary to
> > convert from the planar audio formats that are output by some decoders
> > now to an interleaved audio format.
> 
> Here is a new version of the patch. Support for paletted video formats
> should be back (as far as I can tell from gst-libav1.0's code
> *_set_palette was removed altogether and is no longer needed). Support
> for planar audio formats gives me headaches as too much has been
> changed. I've started to backport it for the encoder but failed to do
> so for the decoder.

Yeah, there's a reason why we did a new version with improved API after
many years of experience with annoyances and unneeded complications like
that ;)

Generally looks good the patch

> In gst-libav1.0 gst_ffmpegauddec_get_buffer gets a GstAudioInfo pointer
> from a GstAudioDecoder* instance. Where do I get that from in
> gstreamer-ffmpeg0.10? Or is there some other way to get the same
> information? The same questions also bugs me for the encoder.

In 0.10 you could create (with later versions of 0.10) a GstAudioInfo
from the GstCaps. See gst/audio/audio.h for the relevant functions.

> Since GstFFmpegDec is not a GstAudioDecoder, what's the proper
> replacement for gst_audio_decoder_allocate_output_buffer? (as used in
> gst-libav1.0's gst_ffmpegauddec_get_buffer)

Just gst_buffer_new_and_alloc()

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to