Attached is a diff of the exported symbols between versions 0.9.4-5.1
and 0.9.5-3.  this should really have had a soname bump, I think,
judging by the amount of changes.   I got the diff with the ugly
construct:
diff -u <(objdump -T 
libdvdread-0.9.4/debian/libdvdread3/usr/lib/libdvdread.so.3.0.0 |grep .text | 
awk '{ print $7 }'|sort) <(objdump -T 
libdvdread-0.9.5/debian/libdvdread3/usr/lib/libdvdread.so.3.1.0 |grep .text | 
awk '{ print $7 }'|sort)

after fixing up the build so that it exports UDFFindFile again.

So, as to why your patch didn't work: you're patching Makefile.am, but
not B-D'ing on an automake, so Makefile{,.in} don't get rebuilt to
reflect the changes.  Changing the dpatch to patch Makefile.in (ugly,
hackish, fragile) does the right thing, but is probably not the best way
to go.  If a buildd has automake installed, it will probably break it,
since dpatch is run before the autofoo would rebuild Makefile.in.

What do you want to do here?  Change the soname, revert the upstream
export changes, something else?  I assume that UDFFindFile was supposed
to be a private symbol all along, and dvdbackup was stupid for using it.
I can try to fix that in dvdbackup, but since the changes are fairly big
in libdvdread, I feel like something should declare the incompatibility
there as well.

Thanks,
-- 
 --------------------------------------------------------------------------
|  Stephen Gran                  | I must have a prodigious quantity of    |
|  [EMAIL PROTECTED]             | mind; it takes me as much as a week     |
|  http://www.lobefin.net/~steve | sometimes to make it up.   -- Mark      |
|                                | Twain, "The Innocents Abroad"           |
 --------------------------------------------------------------------------
--- /proc/self/fd/63    2006-04-29 13:45:04.210095892 +0100
+++ /proc/self/fd/62    2006-04-29 13:45:04.233092316 +0100
@@ -1,10 +1,13 @@
 
+cmdPrint_CMD
+cmdPrint_mnemonic
 DVDClose
 DVDCloseFile
 DVDDiscID
 DVDFileSeek
 DVDFileSize
-dvdinput_setup
+DVDFinish
+DVDInit
 DVDISOVolumeInfo
 DVDOpen
 DVDOpenFile
@@ -12,8 +15,7 @@
 DVDReadBytes
 DVDUDFCacheLevel
 DVDUDFVolumeInfo
-FreeUDFCache
-GetUDFCacheHandle
+DVDVersion
 ifoClose
 ifoFree_C_ADT
 ifoFree_FP_PGC
@@ -57,19 +59,8 @@
 ifoRead_VTS_ATRT
 ifoRead_VTS_PTT_SRPT
 ifoRead_VTS_TMAPT
-md5_buffer
-md5_finish_ctx
-md5_init_ctx
-md5_process_block
-md5_process_bytes
-md5_read_ctx
-md5_stream
 navPrint_DSI
 navPrint_PCI
 navRead_DSI
 navRead_PCI
-SetUDFCacheHandle
 UDFFindFile
-UDFGetVolumeIdentifier
-UDFGetVolumeSetIdentifier
-UDFReadBlocksRaw

Reply via email to