On Monday, June 26, 2023 6:15:06 P.M. CDT Adrian Bunk wrote:
> Control: reassign -1 libinsighttoolkit5-dev 5.3.0-3
> Control: affects -1 src:plastimatch
> 
> There are actually tow separate issues, both in libinsighttoolkit5-dev:

Thanks for bringing this to my attention.

> 1. The VTK build dependencies for the recent VTK changes also hae to
>    become dependencies of libinsighttoolkit5-dev.

I confirmed this bug, and fixed it in a rev -4 upload of ITK.  I confirmed the 
issue and the fix by building elastix, which depends on ITK in the same manner.


> In file included from
> /<<PKGBUILDDIR>>/src/plastimatch/base/dcmtk_config.h:16, from
> /<<PKGBUILDDIR>>/src/plastimatch/base/metadata.h:12, from
> /<<PKGBUILDDIR>>/src/plastimatch/base/astroid_dose.h:8, from
> /<<PKGBUILDDIR>>/src/plastimatch/base/astroid_dose.cxx:7:
> /usr/include/dcmtk/config/osconfig.h:1153:2: error: invalid preprocessing
> directive #errorDCMTK 1153 | #error\
> 
>       |  ^~~~~~
> 
>  1154 | DCMTK was configured to use C++17 features, but your compiler does
> not or was not configured to provide them.
>       | ~~~~~
> 
> 2. This is caused by libinsighttoolkit5-dev injecting -std=c++14 into
>    reverse dependencies, the fix is likely something like


This is less clear to me.  Elastix also build-depends on dcmtk and doesn't 
show this issue.  I think ITK uses C++14 as a minimum but you ought to be able 
to build with higher levels.  At work, we build with a C++20 compiler.

Thus: I am closing this bug with rev -4 fixing the first mentioned issue.  If I 
am wrong about the second, please open a second bug.

Regards,
-Steve

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to