severity 414478 normal thanks On Mon, Mar 12, 2007 at 12:49:25AM +0100, Pierre Habouzit wrote: > Package: dtc > Severity: grave > Justification: renders package unusable > > > in the debian_config script you can find oddities like: > > if [ ""$conf_use_nated_vhosts = "true" -o ""$conf_use_nated_vhosts = > "yes" ] ; then > > or > > if [ ""$RET = "true" -o ""$RET = "yes" ] ; then > > Please learn proper quoting in sh scripting. sh(1) could be a good > start.
Ok, I read too fast here, and was confused. The code is correct, it's just _so_ unusual that I first thought it was a bug. please rather use "$foo" than ""$foo or $foo"" it's _really_ hard to read, and do remember code is written to be read too ;) TIA. -- ·O· Pierre Habouzit ··O [EMAIL PROTECTED] OOO http://www.madism.org
pgpuRnqtK4Lpi.pgp
Description: PGP signature
