-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Pierre Habouzit wrote: > Package: dtc > Severity: grave > Justification: renders package unusable > > > in the debian_config script you can find oddities like: > > if [ ""$conf_use_nated_vhosts = "true" -o ""$conf_use_nated_vhosts = > "yes" ] ; then > > or > > if [ ""$RET = "true" -o ""$RET = "yes" ] ; then > > Please learn proper quoting in sh scripting. sh(1) could be a good > start.
The goal was NOT to quote in this case, but to have the script work if the variable is empty. This does what it was meant to do. After knowing that, do you still think it's wrong? I'll change these anyway, just to make it more "standard" and not shocking to any eyes, but that wont make the script any better to me. Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF9Nqxl4M9yZjvmkkRAm+uAJ9YPUAntbDeT7wwLFK5U9xBkSRUNQCgrUiC FaRzOFhW6TEX9ZzW0/xSkJE= =pCBA -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
